Draft
Conversation
Osyotr
force-pushed
the
windows-lite
branch
2 times, most recently
from
36f706e to
cfd5285
Compare
Osyotr
force-pushed
the
windows-lite
branch
3 times, most recently
from
9c404c1 to
7d71c77
Compare
Osyotr
force-pushed
the
windows-lite
branch
9 times, most recently
from
db1e745 to
1cab00a
Compare
Osyotr
force-pushed
the
windows-lite
branch
3 times, most recently
from
8e5fdc6 to
e73e331
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| UErrorCode icu_error = U_ZERO_ERROR; | ||
| size_t const count = uscript_getScriptExtensions(static_cast<UChar32>(codepoint), scripts.data(), | ||
| int32_t const count = uscript_getScriptExtensions(static_cast<UChar32>(codepoint), scripts.data(), | ||
| static_cast<int32_t>(scripts.max_size()), &icu_error); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| static_cast<int32_t>(scripts.max_size()), &icu_error); | |
| static_cast<int32_t>(scripts.max_size()), &icu_error); |
|
|
||
| std::pair<size_t, size_t> FindSegmentOnShape(std::vector<m2::PointD> const & shape, | ||
| std::pair<uint32_t, uint32_t> FindSegmentOnShape(std::vector<m2::PointD> const & shape, | ||
| std::vector<m2::PointD> const & segment) |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| std::vector<m2::PointD> const & segment) | |
| std::vector<m2::PointD> const & segment) |
|
|
||
| std::pair<size_t, size_t> FindPointsOnShape(std::vector<m2::PointD> const & shape, m2::PointD const & p1, | ||
| std::pair<uint32_t, uint32_t> FindPointsOnShape(std::vector<m2::PointD> const & shape, m2::PointD const & p1, | ||
| m2::PointD const & p2) |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| m2::PointD const & p2) | |
| m2::PointD const & p2) |
| // occurrences of |p1| or |p2| in |shape|, indexes with minimum distance are returned. | ||
| std::pair<size_t, size_t> FindPointsOnShape(std::vector<m2::PointD> const & shape, m2::PointD const & p1, | ||
| std::pair<uint32_t, uint32_t> FindPointsOnShape(std::vector<m2::PointD> const & shape, m2::PointD const & p1, | ||
| m2::PointD const & p2); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| m2::PointD const & p2); | |
| m2::PointD const & p2); |
| // is not found returns pair of zeroes. | ||
| std::pair<size_t, size_t> FindSegmentOnShape(std::vector<m2::PointD> const & shape, | ||
| std::pair<uint32_t, uint32_t> FindSegmentOnShape(std::vector<m2::PointD> const & shape, | ||
| std::vector<m2::PointD> const & segment); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| std::vector<m2::PointD> const & segment); | |
| std::vector<m2::PointD> const & segment); |
Osyotr
force-pushed
the
windows-lite
branch
3 times, most recently
from
e59d85b to
4929fe3
Compare
Signed-off-by: Osyotr <Osyotr@users.noreply.github.com> Don't set LANGUAGE environment variable on Windows Signed-off-by: Osyotr <Osyotr@users.noreply.github.com> Skip (MALI_)MobileCompileShaders_TEST on Windows Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>
Use /fp:fast to match other platforms behavior. Set /bigobj to prevent possible linking errors with static libraries. Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>
Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>
Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>
Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>
Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>
There's no need to support Windows XP :) Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>
Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>
Osyotr
commented
Mar 4, 2026
| }; | ||
|
|
||
| #if defined(OMIM_OS_WINDOWS) //&& defined(PROFILER_COMMON) | ||
| #if 0 && defined(OMIM_OS_WINDOWS) //&& defined(PROFILER_COMMON) |
Owner
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.