Skip to content

Conversation

Copy link

Copilot AI commented Jan 19, 2026

Fixes several issues in the math header and related files discovered during evaluation.

Changes

  • Always.h: Fix typo MinImpMinImpl when _useSTD is defined
  • YRMath.h: Rename sqr(float)sqrt(float) — function was calling std::sqrt but named incorrectly
  • YRMath.h, PaletteManager.cpp: Fix invalid static_assert syntax

static_assert fix

// Before: string literal always evaluates true (non-null pointer)
static_assert("Not supported");

// After: type-dependent false expression, triggers only when instantiated
static_assert(!sizeof(T), "Not supported");
Original prompt

Evaluate YRPP/Math.h and fix


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…atic_assert syntax

Co-authored-by: deathreaperz <37824218+deathreaperz@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issues in YRPP/Math.h header file Fix YRMath.h: typo, naming inconsistency, invalid static_assert syntax Jan 19, 2026
Copilot AI requested a review from deathreaperz January 19, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants