Skip to content

Commit 2a3f5f7

Browse files
author
Zvi Fried
committed
fix: resolve all mypy type checking errors
- Fix importlib_resources import type ignore comments - Update _evaluate_coding_plan function signature to accept list[str] for research_urls - All type checking, linting, formatting, and tests now pass locally: ✅ mypy src - Success: no issues found ✅ ruff check src tests - All checks passed ✅ ruff format --check - 12 files already formatted ✅ pytest - 41/41 tests passing
1 parent ca6722b commit 2a3f5f7

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/mcp_as_a_judge/prompt_loader.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from importlib.resources import files
88
except ImportError:
99
# Python < 3.9 fallback
10-
from importlib_resources import files # type: ignore[import-untyped]
10+
from importlib_resources import files # type: ignore[import-not-found,no-redef]
1111

1212
from jinja2 import Environment, FileSystemLoader, Template
1313
from mcp.types import SamplingMessage, TextContent

src/mcp_as_a_judge/server.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ async def elicit_missing_requirements(
255255

256256
async def _validate_research_quality(
257257
research: str,
258-
research_urls: str,
258+
research_urls: list[str],
259259
plan: str,
260260
design: str,
261261
user_requirements: str,
@@ -372,7 +372,7 @@ async def _evaluate_coding_plan(
372372
plan: str,
373373
design: str,
374374
research: str,
375-
research_urls: str,
375+
research_urls: list[str],
376376
user_requirements: str,
377377
context: str,
378378
ctx: Context,

0 commit comments

Comments
 (0)