With view model #175
Open
With view model #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonkazakov
suggested changes
Nov 6, 2023
Contributor
antonkazakov
left a comment
antonkazakov
left a comment
There was a problem hiding this comment.
Привет. оставил пару комментариев
app/src/main/java/otus/homework/coroutines/data/CatImagesService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/otus/homework/coroutines/presentation/vm/CatsViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/otus/homework/coroutines/presentation/vm/CatsViewModel.kt
Outdated
Show resolved
Hide resolved
|
|
||
| private val _cat = MutableLiveData<Result<Cat>>() | ||
|
|
||
| private val exceptionHandler = CoroutineExceptionHandler { _, e -> |
Contributor
There was a problem hiding this comment.
SocketException нужно обработать в try/catch
Author
There was a problem hiding this comment.
А CoroutineExceptionHandler его не поймает?
Contributor
There was a problem hiding this comment.
Поймает, но идея следующая:
- try/catch или функция runCatching позволяет поймать ошибку и какой то фоллбек реалзиовать, например получил ошибку сети, сходил в БД или Мемкэш, и корутина дальше продолжит работать
- CoroutineExceptionHandler этот механизм уже когда корутина в терминальном состоянии, и например если упало какое-то исключение, которое никто не ожидал, можно его как то дефолтно обработать, например, показав алерт "что-то пошло не так" или просто в логер какой-то сложить
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.