ДЗ #262
Open
ДЗ #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| sealed class Result { | ||
| data class Success(val catData: Cat) : Result() |
There was a problem hiding this comment.
Success по условиям задачи должен быть дженериком
| private val exceptionHandler = CoroutineExceptionHandler { _, e -> | ||
| CrashMonitor.trackWarning("${e.message}") | ||
| _uiState.value = Result.Error( | ||
| Throwable() |
There was a problem hiding this comment.
тут потеряется исходная ошибка, можно использовать e
| // try { | ||
| // val fact = async { catsService.getCatFact() }.await() | ||
| // val catImages:List<CatImage> = async { catsImagesService.getCatImage() }.await() | ||
| // _catsView?.populate(fact, catImages.first()) |
There was a problem hiding this comment.
не стыкуются типы, во вью populate принимает Cat
| // } | ||
| // if (ex is CancellationException) throw ex | ||
| // | ||
| // CrashMonitor.trackWarning("Error") |
There was a problem hiding this comment.
по условиям задачи в CrashMonitor не должны попадать SocketTimeoutException, здесь попадет, плюс не будет тоста по другим эксепшенам, кроме SocketTimeoutException
В остальных случаях логируем исключение в otus.homework.coroutines.CrashMonitor и показываем Toast с exception.message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.