done #265
Open
done #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| override fun onFailure(call: Call<Fact>, t: Throwable) { | ||
| CrashMonitor.trackWarning() | ||
| catch (e: Exception) { | ||
| when (e) { |
There was a problem hiding this comment.
тут будет перехвачено CancellationException, что сломает механизм отмены корутин, нужно прокидывать его дальше
is CancellationException -> throw e
| _result.value = Result.Success(fact) | ||
| } | ||
| catch (e: Exception) { | ||
| CrashMonitor.trackWarning(e) |
There was a problem hiding this comment.
здесь тоже CancellationException
| override fun onCleared() { | ||
| super.onCleared() | ||
| detachView() | ||
| viewModelScope.cancel() |
There was a problem hiding this comment.
viewModelScope сам отменится, это избыточно
| private val catsService: CatsService, | ||
| private val catsServicePics: CatsServicePics | ||
| ) : ViewModel() { | ||
| private var _catsView: ICatsView? = null |
There was a problem hiding this comment.
тут архитектурная проблема, ViewModel в отличие от Presenter ничего не знает о View и не должна хранить на нее ссылку, вью должна сама подписаться на стейты вьюмодели и обновлять свое состояние в соответствии с ними
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.