Hw4/dagger Хубулов Георгий #150
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nent и FragmentReceiverComponent для передачи ApplicationContext
GeorgeBozon
force-pushed
the
HW4/Dagger
branch
from
072c488 to
2893c78
Compare
antonkazakov
suggested changes
Dec 8, 2024
Contributor
antonkazakov
left a comment
antonkazakov
left a comment
There was a problem hiding this comment.
привет. оставил комментарии
| private val colorGenerator: ColorGenerator, | ||
| private val context: Context | ||
| ) { | ||
| @ActivityContext private val context: Context, |
Contributor
There was a problem hiding this comment.
Здесь будет утечка памяти, нельзя делать наследование от androidx.lifecycle.ViewModel
|
|
||
| @Provides | ||
| @ActivityScope | ||
| fun provideEventsReaderWriter() = EventsWriterReader() |
Contributor
There was a problem hiding this comment.
А зачем тебе provides здесь. Достаточно Inject над конструктором
| annotation class ActivityContext | ||
|
|
||
| @Scope | ||
| @Retention(AnnotationRetention.RUNTIME) |
makzimi
reviewed
Aug 30, 2025
Collaborator
makzimi
left a comment
makzimi
left a comment
There was a problem hiding this comment.
Сейчас всё ок! Спасибо за работу. Работу принимаю.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.