Reactive Cats #201
Open
Reactive Cats #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I transferred the network request from retrofit.Call to the RX chain.
Implemented the generateCatFact function.
Implemented the generateCatFactPeriodically function.
Implemented the Get Facts function. I'm not sure if it was necessary to create a separate data stream to request to the network every 2 minutes, but I didn't use coroutines for this and left the RX approach.
This is the first time I've worked with RX, so maybe I haven't done everything very optimized. I tested the application with the Internet turned on and off, and it looks like it works as it should.