修复Binding结构体赋值时抛出的NotImplementedException异常#609
Open
Siuming93 wants to merge 3 commits intoOurpalm:masterfrom
Open
修复Binding结构体赋值时抛出的NotImplementedException异常#609Siuming93 wants to merge 3 commits intoOurpalm:masterfrom
Siuming93 wants to merge 3 commits intoOurpalm:masterfrom
Conversation
liiir1985
requested changes
Dec 3, 2021
| { | ||
| var ct = domain.GetTypeByIndex(dst->Value) as CLRType; | ||
| var binder = ct.ValueTypeBinder; | ||
| v->ObjectType = ObjectTypes.ValueTypeObjectReference; |
Collaborator
There was a problem hiding this comment.
将值类型绑定的对象往object存的语义是将该对象装箱，因此正确的做法应该是调用StackObject.ToObject(esp)拿到object, 再存入mStack[v->Value]中，然后FreeStackValueType(esp);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
当一个做了值类型绑定的结构体赋值给一个object对象,并对一个新的object对象进行赋值时,会抛出NotImplementedException异常.