feat!: Hint input parameter and Format output parameter #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References: https://outsystemsrd.atlassian.net/browse/RMET-2962 BREAKING CHANGE: This adds a new parameter to `scanBarcode` in `OSBARCManagerProtocol`, which is a breaking change
References: https://outsystemsrd.atlassian.net/browse/RMET-2962 BREAKING CHANGE: This modifies the signature of the public `scanBarcode`, but allows for easier addition of new parameters to avoid future breaking changes.
References: https://outsystemsrd.atlassian.net/browse/RMET-2962 BREAKING CHANGE: This modifies the output of the public `scanBarcode`, but allows for easier addition of new output to avoid future breaking changes.
OS-pedrogustavobilro
requested review from
ItsChaceD,
OS-ruimoreiramendes,
alexgerardojacinto,
andredestro and
eric-horodyski
and removed request for
a team
⛔ Snyk checks have failed. 7 issues have been found so far.
⛔ security/snyk check is complete. 7 issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) 💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Because macos-14 comes with more Xcode versions. To be addressed in https://outsystemsrd.atlassian.net/browse/RMET-4424
alexgerardojacinto
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR that allows native library to allow for specifying a Hint - to scan a specific format (e.g. only QR Code, only EAN-8). The format that was scanned is now also returned.
If a Hint is specified that isn't supported in iOS, it will default to allow all formats - a warning could be returned in such scenarios, but I think having updated docs should suffice.
This PR includes BREAKING CHANGES - The signature of the
scanBarcodemethod was changed, but should now allow for easier changes in the future without causing additional breaking changes.Type of changes
Tests
Use the Barcode Demo App in O11 to test this.