Skip to content

RMET-4122 ::: Add onBrowserPageNavigationCompleted event #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andredestro merged 1 commit into from
Mar 20, 2025
Merged

RMET-4122 ::: Add onBrowserPageNavigationCompleted event #15

andredestro merged 1 commit into from
Mar 20, 2025

Conversation

@andredestro
Copy link
Contributor

@andredestro andredestro commented Mar 18, 2025 •
edited
Loading

Description

This PR adds the event onBrowserPageNavigationCompleted, which is triggered when the user navigates on the web view.

Context

https://outsystemsrd.atlassian.net/browse/RMET-4122

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality not to work as expected)

Tests

test_navigateToNewPage_onBrowserPageNavigationCompletedEventShouldBeTrigged

Screenshots (if appropriate)

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows the code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@andredestro andredestro self-assigned this Mar 18, 2025
@andredestro andredestro force-pushed the feat/RMET-4122/navigation-completed-event branch 3 times, most recently from c136531 to 463abac Compare March 18, 2025 14:28
@andredestro andredestro marked this pull request as ready for review March 18, 2025 15:06
@andredestro andredestro requested a review from a team as a code owner March 18, 2025 15:06
@andredestro andredestro force-pushed the feat/RMET-4122/navigation-completed-event branch from 463abac to c1fa2b7 Compare March 19, 2025 15:40
@andredestro andredestro force-pushed the feat/RMET-4122/navigation-completed-event branch from c1fa2b7 to ca805eb Compare March 19, 2025 15:42
@andredestro andredestro merged commit 66737bc into main Mar 20, 2025
4 of 5 checks passed
@andredestro andredestro deleted the feat/RMET-4122/navigation-completed-event branch March 20, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexgerardojacinto alexgerardojacinto alexgerardojacinto approved these changes

@OS-pedrogustavobilro OS-pedrogustavobilro OS-pedrogustavobilro approved these changes

@ItsChaceD ItsChaceD Awaiting requested review from ItsChaceD ItsChaceD is a code owner automatically assigned from OutSystems/rd-mobile-ecosystem

@eric-horodyski eric-horodyski Awaiting requested review from eric-horodyski eric-horodyski is a code owner automatically assigned from OutSystems/rd-mobile-ecosystem

@OS-martacarlos OS-martacarlos Awaiting requested review from OS-martacarlos OS-martacarlos is a code owner automatically assigned from OutSystems/rd-mobile-ecosystem

Assignees

@andredestro andredestro

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andredestro @alexgerardojacinto @OS-pedrogustavobilro