Skip to content

fix: allow iframes to load with OpenInWebView #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andredestro merged 1 commit into from
Oct 2, 2025
Merged

fix: allow iframes to load with OpenInWebView #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,18 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Fixes

- Fix iframe loading issue. [RMET-4517](https://outsystemsrd.atlassian.net/browse/RMET-4517).

## 2.3.0

### Features

- Enable WebKit inspector for debugging on iOS 16.4+ in DEBUG builds.


## 2.2.1

### Fixes
Expand Down
3 changes: 2 additions & 1 deletion Sources/OSInAppBrowserLib/WebView/OSIABWebViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,9 @@ class OSIABWebViewModel: NSObject, ObservableObject {

// MARK: - WKNavigationDelegate implementation
extension OSIABWebViewModel: WKNavigationDelegate {

func webView(_ webView: WKWebView, decidePolicyFor navigationAction: WKNavigationAction, decisionHandler: @escaping (WKNavigationActionPolicy) -> Void) {
guard let url = navigationAction.request.url, url == navigationAction.request.mainDocumentURL else { return decisionHandler(.cancel) }
guard let url = navigationAction.request.url else { return decisionHandler(.cancel) }

// if is an app store, tel, sms, mailto or geo link, let the system handle it, otherwise it fails to load it
if ["itms-appss", "itms-apps", "tel", "sms", "mailto", "geo"].contains(url.scheme) {
Expand Down
Loading