RDMR-1052: decouple bottom nav bar from background color #33
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS-kepatotorica
commented
Jan 12, 2026
| public void overrideBackbutton(boolean override) { | ||
| LOG.i("App", "WARNING: Back Button Default Behavior will be overridden. The backbutton event will be fired!"); | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.BAKLAVA) { | ||
| if (Build.VERSION.SDK_INT >= 36) { // Build.VERSION_CODES.BAKLAVA |
Author
There was a problem hiding this comment.
Node CI / NodeJS 20.x on ubuntu-latest (push)
was failing because of this.
OS-kepatotorica
requested review from
Chuckytuh,
EiyuuZack,
OS-ruialves,
benmccarty91,
trevor-lambert and
usernuno
Chuckytuh
reviewed
Jan 12, 2026
OS-kepatotorica
force-pushed
the
fix/RDMR-1052-decouple-bottom-nav-bar-from-background-color
branch
from
53b40cd to
fbaa71a
Compare
benmccarty91
approved these changes
Jan 14, 2026
OS-ruialves
previously requested changes
Jan 16, 2026
OS-kepatotorica
force-pushed
the
fix/RDMR-1052-decouple-bottom-nav-bar-from-background-color
branch
3 times, most recently
from
0836c11 to
6fc1950
Compare
…plash screen has been drawn to prevent a flash between the native and the custom splash screen
OS-kepatotorica
force-pushed
the
fix/RDMR-1052-decouple-bottom-nav-bar-from-background-color
branch
from
6fc1950 to
4bae33a
Compare
OS-kepatotorica
dismissed
OS-ruialves’s stale review
Talked to Rui, he is now offline.
EiyuuZack
deleted the
fix/RDMR-1052-decouple-bottom-nav-bar-from-background-color
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Our customization of the SplashScreenPlugin leads to the updateSystemBars message getting sent twice if we are using a the legacy splash screen. The problem with this is that between the time that the native splash screen is closed and the legacy splash screen gets displayed in the webview there can be a flash of color when the status bar color is changed, or the navigation bar color is changed, the navigation bar is actually the root view, so the flash is very noticeable. This prevents the changing of those elements until the "final" splash screen has been closed.
Description
If we are using a custom splash screen, we no longer send the updateSystemBars message when the native splash screen is closed, instead only sending it when the custom legacy splash screen is closed. If we are not using a custom splash screen, the message gets sent when the native splash screen is closed.
Testing
I tested by making these same changes in an OutSystems app locally.
Checklist
(platform)if this change only applies to one platform (e.g.(android))