Skip to content

fix(server): add subjectAltName field into self signed certificate #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zouxifeng wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(server): add subjectAltName field into self signed certificate #1429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
047afbc
add subjectAltName field into self signed certificate
zouxifeng Oct 23, 2023
eb766eb
add hostname into the self signed certificate use IP or DNS in SAN field
zouxifeng Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/server_manager/install_scripts/install_server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,20 @@ function generate_certificate() {
local -r CERTIFICATE_NAME="${STATE_DIR}/shadowbox-selfsigned"
readonly SB_CERTIFICATE_FILE="${CERTIFICATE_NAME}.crt"
readonly SB_PRIVATE_KEY_FILE="${CERTIFICATE_NAME}.key"
local SAN_FIELD_PREFIX=""
if [[ ${PUBLIC_HOSTNAME} =~ ^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$ ]]; then
SAN_FIELD_PREFIX="IP"
else
SAN_FIELD_PREFIX="DNS"
fi

declare -a openssl_req_flags=(
-x509 -nodes -days 36500 -newkey rsa:4096
-subj "/CN=${PUBLIC_HOSTNAME}"
-addext "subjectAltName=${SAN_FIELD_PREFIX}:${PUBLIC_HOSTNAME}"
-keyout "${SB_PRIVATE_KEY_FILE}" -out "${SB_CERTIFICATE_FILE}"
)

openssl req "${openssl_req_flags[@]}" >&2
}

Expand Down