Skip to content

Prefer VersionStore::store_version_from_reader#405

Open
CleanCut wants to merge 1 commit intocleancut/s3-testsfrom
cleancut/rm-store-version-from-path
Open

Prefer VersionStore::store_version_from_reader#405
CleanCut wants to merge 1 commit intocleancut/s3-testsfrom
cleancut/rm-store-version-from-path

Conversation

@CleanCut
Copy link
Copy Markdown
Contributor

This PR removes VersionStore::store_version_from_path (and its implementations) in favor of using VersionStore::store_version_from_reader. This makes it more straightforward to maintain the VersionStore trait and its various implementations, and makes it clearer how file bytes are traveling through the various calls.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1de50cdf-825d-4ecf-b32f-5c8ee70fe349

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cleancut/rm-store-version-from-path

Comment @coderabbitai help to get the list of available commands and usage tips.

@CleanCut CleanCut force-pushed the cleancut/s3-tests branch from e689414 to 16d3337 Compare April 1, 2026 03:54
@CleanCut CleanCut force-pushed the cleancut/rm-store-version-from-path branch 2 times, most recently from 510937a to 816bdf6 Compare April 1, 2026 15:36
@CleanCut CleanCut force-pushed the cleancut/s3-tests branch from 1ac0ab1 to 58091e1 Compare April 1, 2026 15:46
@CleanCut CleanCut force-pushed the cleancut/rm-store-version-from-path branch 2 times, most recently from 792882a to a7c773f Compare April 1, 2026 15:48
@CleanCut CleanCut force-pushed the cleancut/s3-tests branch from 6cc41e0 to f2c6737 Compare April 1, 2026 17:13
…in favor of using VersionStore::store_version_from_reader
@CleanCut CleanCut force-pushed the cleancut/rm-store-version-from-path branch from a7c773f to 20dd721 Compare April 1, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant