Prefer VersionStore::store_version_from_reader#405
Open
CleanCut wants to merge 1 commit intocleancut/s3-testsfrom
Open
Prefer VersionStore::store_version_from_reader#405CleanCut wants to merge 1 commit intocleancut/s3-testsfrom
VersionStore::store_version_from_reader#405CleanCut wants to merge 1 commit intocleancut/s3-testsfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
e689414 to
16d3337
Compare
510937a to
816bdf6
Compare
1ac0ab1 to
58091e1
Compare
792882a to
a7c773f
Compare
6cc41e0 to
f2c6737
Compare
…in favor of using VersionStore::store_version_from_reader
a7c773f to
20dd721
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
VersionStore::store_version_from_path(and its implementations) in favor of usingVersionStore::store_version_from_reader. This makes it more straightforward to maintain theVersionStoretrait and its various implementations, and makes it clearer how file bytes are traveling through the various calls.