Skip to content

fractional fees #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hudeintres merged 1 commit into from
Oct 15, 2025
Merged

fractional fees #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions lib/alkanes/alkanes.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/alkanes/alkanes.js.map
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 11 additions & 11 deletions src/alkanes/alkanes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export const createExecutePsbt = async ({
outputCount: 2 + (feeSatEffective > 0n ? 1 : 0),
})

const minFee = Math.max(minTxSize * SAT_PER_VBYTE, 250)
const minFee = Math.max(Math.ceil(minTxSize * SAT_PER_VBYTE), 250)
let minerFee = fee === 0 ? minFee : fee

const totalSpendableUtxos = selectSpendableUtxos(utxos, account.spendStrategy)
Expand All @@ -162,7 +162,7 @@ export const createExecutePsbt = async ({
nonTaprootInputCount: 0,
outputCount: 2 + (feeSatEffective > 0n ? 1 : 0),
})
minerFee = Math.max(newSize * SAT_PER_VBYTE, 250)
minerFee = Math.max(Math.ceil(newSize * SAT_PER_VBYTE), 250)
if (gatheredUtxos.totalAmount < minerFee) {
throw new OylTransactionError(Error('Insufficient balance'))
}
Expand Down Expand Up @@ -272,7 +272,7 @@ export const createWrapBtcPsbt = async ({
outputCount: 3,
})

const minFee = Math.max(minTxSize * SAT_PER_VBYTE, 250)
const minFee = Math.max(Math.ceil(minTxSize * SAT_PER_VBYTE), 250)
let minerFee = fee === 0 ? minFee : fee

let gatheredUtxos = selectSpendableUtxos(utxos, account.spendStrategy)
Expand All @@ -286,7 +286,7 @@ export const createWrapBtcPsbt = async ({
nonTaprootInputCount: 0,
outputCount: 3,
})
minerFee = Math.max(newSize * SAT_PER_VBYTE, 250)
minerFee = Math.max(Math.ceil(newSize * SAT_PER_VBYTE), 250)
if (gatheredUtxos.totalAmount < minerFee) {
throw new OylTransactionError(Error('Insufficient balance'))
}
Expand Down Expand Up @@ -399,7 +399,7 @@ export const createUnwrapBtcPsbt = async ({
outputCount: psbt.txOutputs.length + 2, // already includes the subfrost address, 1 more for potential change, 1 for opreturn
})

const minFee = Math.max(minTxSize * SAT_PER_VBYTE, 250)
const minFee = Math.max(Math.ceil(minTxSize * SAT_PER_VBYTE), 250)
let minerFee = fee === 0 ? minFee : fee

let gatheredUtxos = selectSpendableUtxos(utxos, account.spendStrategy)
Expand All @@ -412,7 +412,7 @@ export const createUnwrapBtcPsbt = async ({
nonTaprootInputCount: 0,
outputCount: psbt.txOutputs.length + 1,
})
minerFee = Math.max(newSize * SAT_PER_VBYTE, 250)
minerFee = Math.max(Math.ceil(newSize * SAT_PER_VBYTE), 250)
if (gatheredUtxos.totalAmount < minerFee) {
throw new OylTransactionError(Error('Insufficient balance'))
}
Expand Down Expand Up @@ -735,7 +735,7 @@ export const actualDeployCommitFee = async ({
provider,
})

const wasmDeploySize = getVSize(Buffer.from(payload.body)) * feeRate;
const wasmDeploySize = Math.ceil(getVSize(Buffer.from(payload.body)) * feeRate);
const deployRevealFee = finalFee + wasmDeploySize * 2 + 546; //very conservative value for deployRevealFee. the excess will be refunded

return { fee: finalFee, deployRevealFee, vsize }
Expand Down Expand Up @@ -793,7 +793,7 @@ export const createDeployCommitPsbt = async ({
nonTaprootInputCount: 0,
outputCount: 2 + (feeSatEffective > 0n ? 1 : 0),
})
const calculatedFee = minFee * feeRate < 250 ? 250 : minFee * feeRate
const calculatedFee = minFee * feeRate < 250 ? 250 : Math.ceil(minFee * feeRate)
let commitFee = fee ? fee : calculatedFee

let psbt = new bitcoin.Psbt({ network: provider.network })
Expand All @@ -811,7 +811,7 @@ export const createDeployCommitPsbt = async ({
network: provider.network,
})

const wasmDeploySize = getVSize(Buffer.from(payload.body)) * feeRate
const wasmDeploySize = Math.ceil(getVSize(Buffer.from(payload.body)) * feeRate)
let revealTxFee = deployRevealFee ? deployRevealFee + inscriptionSats : commitFee + wasmDeploySize + inscriptionSats;
let totalFee = revealTxFee + commitFee + Number(feeSatEffective);
let gatheredUtxos = findXAmountOfSats(
Expand All @@ -825,7 +825,7 @@ export const createDeployCommitPsbt = async ({
nonTaprootInputCount: 0,
outputCount: 2 + (feeSatEffective > 0n ? 1 : 0),
})
commitFee = txSize * feeRate < 250 ? 250 : txSize * feeRate
commitFee = txSize * feeRate < 250 ? 250 : Math.ceil(txSize * feeRate)
revealTxFee = deployRevealFee ? deployRevealFee + inscriptionSats : commitFee + wasmDeploySize + inscriptionSats;
totalFee = commitFee + revealTxFee + Number(feeSatEffective);

Expand Down Expand Up @@ -1751,7 +1751,7 @@ export const createTransactReveal = async ({
payload
})

const revealTxBaseFee = minFee * feeRate < 250 ? 250 : minFee * feeRate
const revealTxBaseFee = minFee * feeRate < 250 ? 250 : Math.ceil(minFee * feeRate)
let revealTxFee = fee === 0 ? revealTxBaseFee : fee
const commitTxOutput = commitPsbt.txOutputs[0]

Expand Down