Conversation
|
Daniel pointed out this method should not be static (tied to class, not instance), or if called without an instance (which triggers the constructor) it will lead to a null pointer exception. Since it is closely related, I will fix this in this PR and then mark it ready for review again. |
…s and changed method call in constructor to reference an instance, adapted tests and made them uniform by using a per-class lifcycle
|
The code looks IMO better, I like that the However, if would be superior to only have one constructor in This would simplify making naive But, it's a minute change. Please implement if you find it useful. |
bugfix, keep allowing null but filter for it and expand warning description. Otherwise running the code with old HPO might crash, which is a bit too strong