Added magicbane damage scaling factor#621
Open
rosemarymouse wants to merge 1 commit intoP3pp3rF1y:1.18.x-devfrom
Open
Added magicbane damage scaling factor#621rosemarymouse wants to merge 1 commit intoP3pp3rF1y:1.18.x-devfrom
rosemarymouse wants to merge 1 commit intoP3pp3rF1y:1.18.x-devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the way many mods and modpacks add to or change the enchanting system, it can be desirable to adjust the magicbane's enchant-based damage output scaling.
This PR adds a scale factor to the config, which acts as an exponent for the total enchantment amount used for calculating magicbane damage. It defaults to 1, making it linear and therefore identical to the current magicbane behavior, but can also be adjusted upward for greater than linear scaling, or downward for less than linear scaling.