Skip to content

undefined Chip, set default to {} for chip-pilot#620

Closed
KeHang-Zhu wants to merge 2 commits intoPAIR-code:chip-pilotfrom
KeHang-Zhu:chip-pilot
Closed

undefined Chip, set default to {} for chip-pilot#620
KeHang-Zhu wants to merge 2 commits intoPAIR-code:chip-pilotfrom
KeHang-Zhu:chip-pilot

Conversation

@KeHang-Zhu
Copy link
Copy Markdown
Contributor

@KeHang-Zhu KeHang-Zhu commented Jul 30, 2025

  1. ensure chipValue is set to default {} if undefined
  2. use ?. to avoid crashing on undefined values
  3. Convert addchip to number before processing in the data export function
  • Tests pass
  • Appropriate changes to documentation are included in the PR

@google-cla
Copy link
Copy Markdown

google-cla bot commented Jul 30, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vivtsai
Copy link
Copy Markdown
Collaborator

vivtsai commented Aug 4, 2025

We discussed offline and fixed the issue via the following commits:

@vivtsai vivtsai closed this Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants