-
Notifications
You must be signed in to change notification settings - Fork 24
Add user templates for experiments. #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…up in later commit.
| ${this.experimentEditor.savedTemplates.length > 0 | ||
| ? html` | ||
| <div class="gallery-section"> | ||
| <div class="gallery-title">Saved Templates</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Your Saved Templates" to be more explicit?
|
@aldenhallak FYI, the current experiment endpoint leaves potential support for experiment templates (in that you can specify saving to a templates collection). If you're not planning on using this path, perhaps clean it up and/or alter any documentation? https://github.com/PAIR-code/deliberate-lab/blob/main/functions/src/experiment.endpoints.ts#L27 |
|
Experiments.webm |
|
Done 1 and 2 -- should we do 3 in this PR? I feel like we need to explore a good template discovery method. @cjqian |
|
Here's how two different experimenters can use templates together Multiple.experimenters.vibe.webm |
|
Add checkbox for "Make template globally public" s/ public / sharable while you're at it! |
…isibility options.
Sharing.experiments.1.webmI didn't s/public/sharable because there's now a difference between public and sharable. LMK what you think! @cjqian |
…y sharing settings (open to changing this)
frontend/src/components/experiment_builder/save_template_dialog.ts
Outdated
Show resolved
Hide resolved
frontend/src/components/experiment_builder/save_template_dialog.ts
Outdated
Show resolved
Hide resolved
frontend/src/components/experiment_builder/share_template_dialog.ts
Outdated
Show resolved
Hide resolved
frontend/src/components/experiment_builder/share_template_dialog.ts
Outdated
Show resolved
Hide resolved
…simplify experiment write endpoint input. (addressing viv's comments)
|
Thanks! Merging this into |




Description
We can now create templates in the experiment stages component. We can see and load those templates as well.
Add.user.templates.webm
Verification
Related issues
This PR fixes: #870