Allow admins to make updates to any experiment. #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivtsai
requested changes
Dec 15, 2025
Collaborator
vivtsai
left a comment
vivtsai
left a comment
There was a problem hiding this comment.
The title of the PR is misleading—it says "updates to any experiment," but the changes here are only regarding cohort editing (not, for instance, experiment deletion). Could we either rename the PR or include the other update cases?
vivtsai
requested changes
Dec 15, 2025
functions/src/utils/auth-guard.ts
Outdated
| const allowlistDoc = await app | ||
| .firestore() | ||
| .collection('allowlist') | ||
| .doc(email || '') |
Collaborator
There was a problem hiding this comment.
The empty string case will throw a Firebase error—maybe just check for whether email is valid before this line?
vivtsai
requested changes
Dec 15, 2025
Collaborator
vivtsai
left a comment
vivtsai
left a comment
There was a problem hiding this comment.
One more thing! I'm thinking we want this check to be in the functions in functions/src/experiment.utils.ts so that the REST API calls also enable admins to edit. WDYT?
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
…AdminEmail` checks into utility functions and removing `isCreatorOrAdmin` checks from endpoints.
vivtsai
requested changes
Dec 15, 2025
vivtsai
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a user has isAdmin: true, they should be able to modify any experiment.
Modify.backed.webm
Related issues
This PR fixes: #916, #824