Conversation
The design of Result comes from original code as a replacement for Optional. The thing is: we do not allow storage of nulls, hence we do not have a use for a Optional.ofNullable() equivalent and therefore end up allocating a result based on LNode/SNode value. Make Result an enum with a single value RESTART, replacing TrieMap.RESTART, just like we have had for LookupResult and switch to using it for both lookup and insert cases. The conversion is: - null becomes 'RESTART' (with a static import) - Result.empty() becomes 'null' - Result.isPresent() becomes '!= null' - Result.orNull() becomes nothing Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
The if/return check can be simplified into an expression, let's take advantage of that. Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesign this class to do what LookupResult used to do -- be just a
singleton indicator of restart. This allows us to ditch object
allocation from insert return paths.
Signed-off-by: Robert Varga robert.varga@pantheon.tech