Remove fixed locals for iterators #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
force-pushed
the
iterator_locals
branch
4 times, most recently
from
2bd911a to
2a37ef7
Compare
NWilson
reviewed
Nov 12, 2024
ChangeLog
Outdated
| repeats inside a repeated bracket might be incorrectly checked. | ||
|
|
||
| 25. Fixed a bug in JIT affecting caseful matching of backreferences. When | ||
| utf is disabled, and dupnames is enabled, casesless matching is used instead |
Member
There was a problem hiding this comment.
When you say "caseless matching is used" do you mean, "caseless matching was used, and the behaviour has now been fixed to be caseful"?
zherczeg
force-pushed
the
iterator_locals
branch
from
2a37ef7 to
e321065
Compare
Also fixes a bug in JIT affecting caseful matching of backreferences.
zherczeg
force-pushed
the
iterator_locals
branch
from
e321065 to
9dc524c
Compare
Member
|
This is another of those JIT patches I can't really review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a trivial patch, fuzzing will be useful. Fixes a bug in caseful matching as well.