Move character matching code into pcre2_jit_char_inc.h #569
+2,350
−2,297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I wonder if we shoukd start doing more feature branches to make reviewing this much easier. IMHO we coud still keep history flat (like it was with subversion) by forcing squash merging at the end, and maybe even have better merge commits with some smallwork in tooling and some standardization. |
Collaborator
Author
|
Possible, but this patch is not related to eclass, just a generic structure improvement. JIT is hard to cut into pieces, because too many dependencies in the code. |
Useful for eclass jit implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large code movement patch. No functionality change. Based on #567