Auto-format and minimal cleanup to CMake #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NWilson
force-pushed
the
user/niwilson/cmake-format
branch
from
838321e to
b86534b
Compare
Collaborator
|
This destroys history. Do we gain anything? |
Member
Author
|
It's unpleasantly inconsistent to look at. Previous tickets (such as #115) have mentioned that the style and capitalisation don't match CMake standards. The history is still all there. It's not too hard to make |
Collaborator
|
I am neutral for this change. @carenas what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tackled any controversial steps in this PR - simply tidying the formatting.
I have used the
gersemitool, which simply "does its thing". I have additionally renamed a few variables to match standard casing conventions (but I am aware that some lowercased variables are used, for example in package-config files, and have left those alone).