Fix some Clang warnings with -Wshorten-64-to-32#689
Merged
Conversation
NWilson
commented
Feb 9, 2025
| compare_type compare2_type = compare_match1; | ||
| vect_t cmp1a, cmp1b, cmp2a, cmp2b; | ||
| const sljit_u32 diff = IN_UCHARS(offs1 - offs2); | ||
| const sljit_uw diff = IN_UCHARS(offs1 - offs2); |
Member
Author
There was a problem hiding this comment.
@zherczeg I just wanted to point out this small change in the NEON code. I think it's correct.
Collaborator
There was a problem hiding this comment.
Likely. diff is a value between 0 and 31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses Aaron's (ucko's) complaint from #655.