Skip to content

Build fixes for z/OS#695

Merged
NWilson merged 5 commits intomasterfrom
user/niwilson/zos
Feb 26, 2025
Merged

Build fixes for z/OS#695
NWilson merged 5 commits intomasterfrom
user/niwilson/zos

Conversation

@NWilson
Copy link
Member

@NWilson NWilson commented Feb 11, 2025

No description provided.

@NWilson
Copy link
Member Author

NWilson commented Feb 17, 2025

I received some help from z/OS users, who were trying out the build & tests on z/OS for me. IBM said they'd grant me access to a test system, but that was a while ago, so I'll see how that works out.

I can't really merge this until I hear back that it works, or am able to verify it myself.

The build fixes are good - but extra small changes might be needed in RunTest in order to get the tests all passing.

@NWilson NWilson force-pushed the user/niwilson/zos branch 4 times, most recently from 4eab724 to 7abc95d Compare February 25, 2025 21:35
Copy link
Collaborator

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@NWilson
Copy link
Member Author

NWilson commented Feb 26, 2025

I was granted access to a test system. I didn't spend that long on this, in the end, and it turned out to be not much extra work to actually support z/OS.

I don't feel strongly about it. I am glad though that I now know for certain that the EBCDIC code works. I didn't feel comfortable shipping it as untested and bitrotted code.

If we do ever drop z/OS support, then I would purge the EBCDIC code from the source tree, rather than leave it as dubious abandoned ifdefs.

@NWilson NWilson merged commit 929b740 into master Feb 26, 2025
34 checks passed
@NWilson NWilson deleted the user/niwilson/zos branch February 26, 2025 22:31
@zherczeg
Copy link
Collaborator

If you are willing to maintain the port, I have no objection to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants