-
Notifications
You must be signed in to change notification settings - Fork 242
pcre2test: improve binmode
#778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zherczeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice!
|
Thank you Carlo for all these PRs! I've been extremely busy this week at home and hardly had a minute to look at anything PCRE2. I'm sorry - I'll deal with all of them next week. |
Report parameters for OP_[V]REVERSE, avoid ambiguous back references, simplify code and update related documentation.
NWilson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That looks tidy
| @@ -1,4 +1,4 @@ | |||
| .TH PCRE2PATTERN 3 "29 August 2025" "PCRE2 10.47-DEV" | |||
| .TH PCRE2PATTERN 3 "2 September 2025" "PCRE2 10.47-DEV" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future, you don't worry about updating this manually in the PR. I'll just do it once automatically using maint/UpdateDates before a release. It's completely harmless to do manually, just not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this file used to generate the documentation in github though or that also gets its dates updated automatically?, Philip's argument for updating the date in this case was that API changes that might be relevant since the previous release are not easily identifiable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The *.1 and *.3 files are canonical, you are correct. The dates however can be updated automatically, to simply match the last commit date in the history (excluding commits which only bump the version number).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I am not clear though, if by that you mean that they are being updated already whenever the documentation gets updated or not.
Simplify the code and print all parameters