Skip to content

Conversation

@carenas
Copy link
Contributor

@carenas carenas commented Aug 22, 2025

Simplify the code and print all parameters

Copy link
Collaborator

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice!

@NWilson
Copy link
Member

NWilson commented Aug 23, 2025

Thank you Carlo for all these PRs!

I've been extremely busy this week at home and hardly had a minute to look at anything PCRE2. I'm sorry - I'll deal with all of them next week.

Report parameters for OP_[V]REVERSE, avoid ambiguous back references,
simplify code and update related documentation.
Copy link
Member

@NWilson NWilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That looks tidy

@@ -1,4 +1,4 @@
.TH PCRE2PATTERN 3 "29 August 2025" "PCRE2 10.47-DEV"
.TH PCRE2PATTERN 3 "2 September 2025" "PCRE2 10.47-DEV"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future, you don't worry about updating this manually in the PR. I'll just do it once automatically using maint/UpdateDates before a release. It's completely harmless to do manually, just not necessary.

Copy link
Contributor Author

@carenas carenas Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this file used to generate the documentation in github though or that also gets its dates updated automatically?, Philip's argument for updating the date in this case was that API changes that might be relevant since the previous release are not easily identifiable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The *.1 and *.3 files are canonical, you are correct. The dates however can be updated automatically, to simply match the last commit date in the history (excluding commits which only bump the version number).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I am not clear though, if by that you mean that they are being updated already whenever the documentation gets updated or not.

@NWilson NWilson merged commit 498bef0 into PCRE2Project:master Sep 3, 2025
35 checks passed
@carenas carenas deleted the binmode branch September 3, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants