maint: build fix for ucptest and related code tyding up #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NWilson
reviewed
Aug 31, 2025
Comment on lines
85
to
86
| for (i = 0; i < PRIV(utf8_table1_size); i++) | ||
| if ((int)cvalue <= PRIV(utf8_table1)[i]) break; |
Member
There was a problem hiding this comment.
Wow, this writes out a rather weird & ill-formed sequence if you pass in cvalue = 0xffff_ffff. However that value shouldn't be passed in, and the code doesn't do any bad loops or out-of-bounds access. So, I guess it's OK.
Contributor
Author
There was a problem hiding this comment.
correct, I almost threw it a PCRE2_ASSERT there as that function shouldn't be getting anything over 0x10ffff anyway AFAIK, at least when called from the library.
Member
|
Ah - the CI is failing. It looks like you need to find all the other uses of |
carenas
commented
Aug 31, 2025
Since 9a868b0 (Tidy up config.h management (task from README) (PCRE2Project#658), 2025-01-11), it fails to build with an "#error" because "config.h" is no longer included directly. Move the check and change some types in the utf8 tables it uses through pcre2_ord2utf() so it better matches its current use, and other changes in pcre2test. While at it fix a typo in ManyConfigTests that was introduced in 0d0ac3a (Update EBCDIC support to support testing on normal ASCII systems (PCRE2Project#656), 2025-02-12)
NWilson
approved these changes
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly fix a simple build failure because of the removal of the "config.h" include, but also some "fixes" for a "-Weverything" build and other tidying up of the code that made sense.