ci: group dependabot updates #84
clippy
49 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 49 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.85.0 (4d91de4e4 2025-02-17)
- cargo 1.85.0 (d73d2caf9 2024-12-31)
- clippy 0.1.85 (4d91de4e48 2025-02-17)
Annotations
Check warning on line 300 in src/api/v1.rs
github-actions / clippy
variable `pageSize` should have a snake case name
warning: variable `pageSize` should have a snake case name
--> src/api/v1.rs:300:5
|
300 | pageSize: Option<i32>,
| ^^^^^^^^ help: convert the identifier to snake case: `page_size`
Check warning on line 261 in src/api/v1.rs
github-actions / clippy
variable `pageSize` should have a snake case name
warning: variable `pageSize` should have a snake case name
--> src/api/v1.rs:261:5
|
261 | pageSize: Option<i32>,
| ^^^^^^^^ help: convert the identifier to snake case: `page_size`
|
= note: `#[warn(non_snake_case)]` on by default
Check warning on line 67 in src/main.rs
github-actions / clippy
equality checks against true are unnecessary
warning: equality checks against true are unnecessary
--> src/main.rs:67:8
|
67 | if verbose_logging == true {
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `verbose_logging`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
= note: `#[warn(clippy::bool_comparison)]` on by default
Check warning on line 63 in src/main.rs
github-actions / clippy
this `map_or` can be simplified
warning: this `map_or` can be simplified
--> src/main.rs:63:9
|
63 | dotenvy::var("VERBOSE_LOGGING").map_or(false, |val| val.to_lowercase().eq("true"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use is_ok_and instead: `dotenvy::var("VERBOSE_LOGGING").is_ok_and(|val| val.to_lowercase().eq("true"))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
= note: `#[warn(clippy::unnecessary_map_or)]` on by default
Check warning on line 22 in src/util.rs
github-actions / clippy
this boolean expression can be simplified
warning: this boolean expression can be simplified
--> src/util.rs:22:12
|
22 | if !part.parse::<i64>().is_ok() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `part.parse::<i64>().is_err()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
= note: `#[warn(clippy::nonminimal_bool)]` on by default
Check warning on line 111 in src/storage/sync.rs
github-actions / clippy
unnecessary closure used to substitute value for `Result::Err`
warning: unnecessary closure used to substitute value for `Result::Err`
--> src/storage/sync.rs:109:13
|
109 | / rocket::futures::TryStreamExt::try_next(&mut archive_release_stream)
110 | | .await
111 | | .unwrap_or_else(|err| None)
| |___________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
help: use `unwrap_or` instead
|
111 | .unwrap_or(None)
| ~~~~~~~~~~~~~~~
Check warning on line 72 in src/storage/sync.rs
github-actions / clippy
unnecessary closure used to substitute value for `Result::Err`
warning: unnecessary closure used to substitute value for `Result::Err`
--> src/storage/sync.rs:70:35
|
70 | while let Some(release) = rocket::futures::TryStreamExt::try_next(&mut main_release_stream)
| ___________________________________^
71 | | .await
72 | | .unwrap_or_else(|err| None)
| |_______________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
help: use `unwrap_or` instead
|
72 | .unwrap_or(None)
| ~~~~~~~~~~~~~~~
Check warning on line 129 in src/storage/sync.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> src/storage/sync.rs:129:5
|
129 | return false;
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
129 - return false;
129 + false
|
Check warning on line 109 in src/storage/models.rs
github-actions / clippy
manual implementation of `Option::map`
warning: manual implementation of `Option::map`
--> src/storage/models.rs:104:34
|
104 | published_timestamp: match &github_release.published_at {
| __________________________________^
105 | | Some(published_at) => {
106 | | Some(published_at.to_rfc3339_opts(SecondsFormat::Millis, true))
... |
109 | | },
| |_____________^ help: try: `github_release.published_at.as_ref().map(|published_at| published_at.to_rfc3339_opts(SecondsFormat::Millis, true))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
= note: `#[warn(clippy::manual_map)]` on by default
Check warning on line 71 in src/storage/models.rs
github-actions / clippy
use of `or_insert_with` to construct default value
warning: use of `or_insert_with` to construct default value
--> src/storage/models.rs:71:18
|
71 | .or_insert_with(Vec::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `#[warn(clippy::unwrap_or_default)]` on by default
Check warning on line 56 in src/storage/models.rs
github-actions / clippy
accessing first element with `filename_matches.get(0)`
warning: accessing first element with `filename_matches.get(0)`
--> src/storage/models.rs:56:37
|
56 | if let Some(captures) = filename_matches.get(0) {
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `filename_matches.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
Check warning on line 78 in src/guards.rs
github-actions / clippy
this `let...else` may be rewritten with the `?` operator
warning: this `let...else` may be rewritten with the `?` operator
--> src/guards.rs:76:5
|
76 | / let Some(digest) = header.strip_prefix("sha256=") else {
77 | | return None;
78 | | };
| |______^ help: replace it with: `let digest = header.strip_prefix("sha256=")?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
= note: `#[warn(clippy::question_mark)]` on by default
Check warning on line 70 in src/guards.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/guards.rs:70:16
|
70 | mac.update(&content);
| ^^^^^^^^ help: change this to: `content`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 50 in src/guards.rs
github-actions / clippy
redundant closure
warning: redundant closure
--> src/guards.rs:50:23
|
50 | .and_then(|header| parse_signature(header))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `parse_signature`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
Check warning on line 38 in src/guards.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'r
warning: the following explicit lifetimes could be elided: 'r
--> src/guards.rs:38:29
|
38 | async fn from_data_impl<'r>(
| ^^
39 | request: &Request<'_>,
40 | data: Data<'r>,
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
Check warning on line 24 in src/external/github.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> src/external/github.rs:24:5
|
24 | return Ok(release.items.first().unwrap().tag_name.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
24 - return Ok(release.items.first().unwrap().tag_name.clone());
24 + Ok(release.items.first().unwrap().tag_name.clone())
|
Check warning on line 11 in src/external/github.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> src/external/github.rs:11:5
|
11 | return Ok(release.items.first().unwrap().tag_name.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
11 - return Ok(release.items.first().unwrap().tag_name.clone());
11 + Ok(release.items.first().unwrap().tag_name.clone())
|
Check warning on line 145 in src/api/v2.rs
github-actions / clippy
redundant closure
warning: redundant closure
--> src/api/v2.rs:145:22
|
145 | .map(|db_release| Release::from_database(db_release))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Release::from_database`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
Check warning on line 104 in src/api/v2.rs
github-actions / clippy
manual implementation of an assign operation
warning: manual implementation of an assign operation
--> src/api/v2.rs:104:25
|
104 | combined_notes = combined_notes + content.as_str();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `combined_notes += content.as_str()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `#[warn(clippy::assign_op_pattern)]` on by default
Check warning on line 71 in src/api/v2.rs
github-actions / clippy
redundant closure
warning: redundant closure
--> src/api/v2.rs:71:14
|
71 | .map(|db_release| Release::from_database(db_release))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Release::from_database`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
Check warning on line 66 in src/api/v2.rs
github-actions / clippy
redundant closure
warning: redundant closure
--> src/api/v2.rs:66:14
|
66 | .map(|db_release| Release::from_database(db_release))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Release::from_database`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
Check warning on line 317 in src/api/v1.rs
github-actions / clippy
redundant closure
warning: redundant closure
--> src/api/v1.rs:317:22
|
317 | .map(|db_release| ReleaseV1::from_v2(db_release))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `ReleaseV1::from_v2`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
Check warning on line 279 in src/api/v1.rs
github-actions / clippy
redundant closure
warning: redundant closure
--> src/api/v1.rs:279:22
|
279 | .map(|db_release| ReleaseV1::from_v2(db_release))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `ReleaseV1::from_v2`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
Check warning on line 225 in src/api/v1.rs
github-actions / clippy
redundant closure
warning: redundant closure
--> src/api/v1.rs:225:14
|
225 | .map(|db_release| ReleaseV1::from_v2(db_release))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `ReleaseV1::from_v2`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
Check warning on line 219 in src/api/v1.rs
github-actions / clippy
redundant closure
warning: redundant closure
--> src/api/v1.rs:219:14
|
219 | .map(|db_release| ReleaseV1::from_v2(db_release))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `ReleaseV1::from_v2`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default