Skip to content

Commit e4bf20e

Browse files
committed
Enable unit tests for PDALGetPipelineMetadata and PDALGetPipelineLog
The results of PDALGetPipelineLog are currently unasserted because with the current test pipeline they are always empty regardless of the logging level.
1 parent de6bf3b commit e4bf20e

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

tests/pdal/capi/PipelineTest.c.in

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -135,20 +135,17 @@ TEST testPDALGetSetPipelineLog(void)
135135
ASSERT(count > 0);
136136

137137
// Test valid cases: 0 to 8
138-
//char log[1024];
138+
char log[1024];
139139

140140
for (int i = 0; i < 9; ++i)
141141
{
142142
PDALSetPipelineLogLevel(pipeline, i);
143143
int j = PDALGetPipelineLogLevel(pipeline);
144144
ASSERT_EQ(i, j);
145-
146-
//size_t n = PDALGetPipelineLog(pipeline, log, 1024);
147-
//printf("---- Log Level %d: %d bytes ----\n%s\n", i, n, log);
148145
}
149146

150147
// TODO Determine why all levels yield empty logs
151-
//size_t size = PDALGetPipelineLog(pipeline, log, 1024);
148+
size_t size = PDALGetPipelineLog(pipeline, log, 1024);
152149
//ASSERT(size > 0 && size <= 1024);
153150
//ASSERT_FALSE(log[0] == '\0');
154151

@@ -194,6 +191,7 @@ GREATEST_SUITE(PipelineTest)
194191
RUN_TEST(testPDALExecutePipeline);
195192
RUN_TEST(testPDALGetSetPipelineLog);
196193
RUN_TEST(testPDALGetPipelineAsString);
194+
RUN_TEST(testPDALGetPipelineMetadata);
197195
RUN_TEST(testPDALGetPipelineSchema);
198196
RUN_TEST(testPDALValidatePipeline);
199197

0 commit comments

Comments
 (0)