AffinePriv implies P2Child

Author: mohawk2

Changes

@@ -8,7 +8,7 @@
 - add %PDL::{Math,Ops}::got_complex to record whether have complex versions
 - MatrixOps::svd now handles transpose transparently
 - all ops with two-way dataflow now work as lvalues
-- AffinePriv now implies TwoWay
+- AffinePriv now implies TwoWay and P2Child
 
 2.103 2026-03-03
 - fix regression in *linvals so takes ndarrays as start and end again

lib/PDL/PP.pm

@@ -1212,8 +1212,9 @@ $PDL::PP::deftbl =
        'Cannot have both P2Child and GenericTypes defined'),
    PDL::PP::Rule::Croak->new([qw(P2Child Inplace)],
        'Cannot have both P2Child and Inplace defined'),
+   PDL::PP::Rule::Returns::One->new('P2Child', 'AffinePriv', 'AffinePriv => P2Child'),
    PDL::PP::Rule->new([qw(Pars HaveBroadcasting GenericTypes DefaultFlow AllFuncHeader RedoDimsFuncHeader)],
-		      ["P2Child","Name","StructName"],
+		      [qw(P2Child Name StructName)],
       sub {
         my (undef,$name,$sname) = @_;
         ("PARENT(); [oca]CHILD();",0,[PDL::Types::ppdefs_all()],1,

lib/PDL/PP.pod

@@ -2588,7 +2588,7 @@ transformation back to the parent when C<BackCode> is supplied.
 
 Flag to indicate this is an affine transformation whose C<Priv> (contents
 of the C<pdl_trans>) contains data that will need allocating and freeing.
-As of 2.104, implies C<TwoWay>.
+As of 2.104, implies C<TwoWay> and C<P2Child>.
 
 =head3 GlobalNew
 
@@ -2603,6 +2603,7 @@ Forces C<Pars> to be C<PARENT> and C<CHILD>, the function's
 C<GenericTypes> to be all of them, no C<HaveBroadcasting> or C<CallCopy>,
 and turns on C<DefaultFlow> (so do not supply any of those args).
 Intended for affine transformations with dataflow.
+As of 2.104, implied by C<AffinePriv>.
 
 =head3 DefaultFlow
 

lib/PDL/Slices.pd

@@ -1411,7 +1411,6 @@ EOF
 
 pp_def('xchg',
         OtherPars => 'PDL_Indx n1; PDL_Indx n2;',
-        P2Child => 1,
         AffinePriv => 1,
         EquivDimCheck =>pp_line_numbers(__LINE__, <<'EOF'),
           if ($COMP(n1) <0)
@@ -1574,7 +1573,6 @@ EOD
 
 pp_def('mv',
         OtherPars => 'PDL_Indx n1; PDL_Indx n2;',
-        P2Child => 1,
         AffinePriv => 1,
         CHeader => <<'EOF',
 #define EQUIVDIM(dima,dimb,cdim,inc) \
@@ -1715,7 +1713,6 @@ negative and will then be counted from the last dim backwards
 in the usual way (-1 = last dim).
 =cut
 EOD
-        P2Child => 1,
         AffinePriv => 1,
         OtherPars => join('', map "PDL_Indx $_;", qw(nthdim step nlags)),
         RedoDims => pp_line_numbers(__LINE__, <<'EOF'),
@@ -1772,7 +1769,6 @@ the expression
 is always true (C<m> has to be less than 3).
 =cut
 EOD
-        P2Child => 1,
         OtherPars => join('', map "PDL_Indx $_;", qw(nthdim nsp)),
         AffinePriv => 1,
         RedoDims => pp_line_numbers(__LINE__, <<'EOF'),
@@ -1845,7 +1841,6 @@ Put some dimensions to a broadcastid.
 
  $y = $x->broadcastI(0,1,5); # broadcast over dims 1,5 in id 1
 EOD
-        P2Child => 1,
         AffinePriv => 1,
         OtherPars => "PDL_Indx id; PDL_Indx whichdims[]",
         Comp => 'PDL_Indx nrealwhichdims',
@@ -1924,7 +1919,6 @@ All broadcasted dimensions are made real again.
 See [TBD Doc] for details and examples.
 =cut
 EOD
-        P2Child => 1,
         AffinePriv => 1,
         OtherPars => 'PDL_Indx atind;',
         RedoDims => pp_line_numbers(__LINE__, <<'EOF'),
@@ -2304,7 +2298,6 @@ sub PDL::slice :lvalue {
     $o;
 }
 EOD-slice
-        P2Child => 1,
         OtherPars => 'pdl_slice_args *arglist;',
 #
 # Comp stash definitions:
@@ -2428,7 +2421,6 @@ EOF
 );
 
 pp_def('diagonal',
-        P2Child => 1,
         AffinePriv => 1,
         OtherPars => 'PDL_Indx whichdims[]',
         MakeComp => pp_line_numbers(__LINE__-1, '