Dataflow.pod: minor correction to text and added tags#531
Dataflow.pod: minor correction to text and added tags#531mohawk2 merged 1 commit intoPDLPorters:masterfrom
Conversation
|
Is this the PR with the merge commit in it? I can't see it from If it is, I'll close this and re-open with a properly rebased branch. |
|
Are you saying you think I commented about a merge commit on the wrong PR? Also, are you saying your approach to a PR-ed branch having the wrong contents is to close the PR and open a different one? (rather than fixing it and force-pushing) |
I didn't get the merge commit comment on the benchmark PR, because I thought I'd been a good little boy whereas this PR started 18 commits later and I might have slipped up here instead. Now thinking about it, I may have hit the Github Sync Fork button which looks like it merge commits rather than rebases.
That's the documented procedure I'm still trying to undo 4 years of merge commit muscle-memory, but I think I've finally got the pull from upstream, rebase and force-push loop in my head. |
Added POD code tags to some bare variables in text, e.g. from $y to
$y