Skip to content

Conversation

@HaraldJoerg
Copy link
Contributor

As discussed on IRC:

  • Minor bugfix: Requires 'PDL' instead of 'PDL::Basic'
  • The script now creates MANIFEST, MANIFEST.SKIP and .gitigignore files for bookkeeping
  • The script writes one line what it does
  • POD is adapted to the new "deep" mode results

The second commit recommends pptemplate in the documentation of PDL::PP.

Further ideas:

  • The error messages of pptemplate are rather dry. Using autodie would bring an improvement, but I know that many people are uncomfortable not checking the return code of open etc.
  • I did a manual test which could be automated as an xt test:
    1 pptemplate PDL:Some:Module
    2 cd PDL-Some-Module
    3 git init
    4 git status > /tmp/before
    5 perl Makefile.PL
    6 make
    7 make distcheck # should pass, i.e. not mention MANIFEST
    8 make dist
    9 git status > /tmp/after
    10 git diff /tmp/before /tmp/after # must be empty

 + Minor bugfix: Requires 'PDL' instead of 'PDL::Basic'

 + The script now creates MANIFEST, MANIFEST.SKIP and .gitigignore
   files for bookkeeping

 + The script writes one line what it does

 + POD is adapted to the new "deep" mode results
@coveralls
Copy link

coveralls commented Apr 13, 2025

Coverage Status

coverage: 67.399%. remained the same
when pulling 29ceb49 on HaraldJoerg:pptemplate-files
into 146e9bb on PDLPorters:master.

Copy link
Member

@mohawk2 mohawk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is great! A couple of change are needed.

 + Shebang reverted

 + MANIFEST.SKIP patterns narrowed down
@mohawk2 mohawk2 merged commit 97d7985 into PDLPorters:master Apr 13, 2025
79 checks passed
@HaraldJoerg HaraldJoerg deleted the pptemplate-files branch April 13, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants