Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions api/v3/atom_validation.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,33 @@ func ValidateOwnerInfo(c client.Client, atom *Atom, allErrs *field.ErrorList) {

if ownerInfo.Spec.Atom == nil {
*allErrs = append(*allErrs, field.Required(fieldPath, "spec.Atom missing in "+ownerInfo.Name))
} else {
validateMetadataTemplates(atom, ownerInfo, allErrs)
}
}

func validateMetadataTemplates(atom *Atom, ownerInfo *smoothoperatorv1.OwnerInfo, allErrs *field.ErrorList) {
var metadataTemplates []string
if atom.Spec.Service.ServiceMetadataLinks != nil {
metadataTemplates = atom.Spec.Service.ServiceMetadataLinks.Templates
}
for _, feed := range atom.Spec.Service.DatasetFeeds {
if feed.DatasetMetadataLinks != nil {
metadataTemplates = append(metadataTemplates, feed.DatasetMetadataLinks.Templates...)
}
}

if len(metadataTemplates) > 0 {
fieldPath := field.NewPath("spec").Child("service").Child("ownerInfoRef")
if slices.Contains(metadataTemplates, "csw") && (ownerInfo.Spec.MetadataUrls == nil || ownerInfo.Spec.MetadataUrls.CSW == nil) {
*allErrs = append(*allErrs, field.Required(fieldPath, "spec.metadataUrls.csw missing in "+ownerInfo.Name))
}
if slices.Contains(metadataTemplates, "html") && (ownerInfo.Spec.MetadataUrls == nil || ownerInfo.Spec.MetadataUrls.HTML == nil) {
*allErrs = append(*allErrs, field.Required(fieldPath, "spec.metadataUrls.html missing in "+ownerInfo.Name))
}
if slices.Contains(metadataTemplates, "opensearch") && (ownerInfo.Spec.MetadataUrls == nil || ownerInfo.Spec.MetadataUrls.OpenSearch == nil) {
*allErrs = append(*allErrs, field.Required(fieldPath, "spec.metadataUrls.opensearch missing in "+ownerInfo.Name))
}
}
}

Expand Down
105 changes: 0 additions & 105 deletions api/v3/atom_validation_test.go

This file was deleted.

60 changes: 0 additions & 60 deletions api/v3/test_data/input/1-no-error-no-warning.yaml

This file was deleted.

60 changes: 0 additions & 60 deletions api/v3/test_data/input/2-warning-atom-name.yaml

This file was deleted.

60 changes: 0 additions & 60 deletions api/v3/test_data/input/3-error-dataset-metadata-id.yaml

This file was deleted.

This file was deleted.

Loading
Loading