Skip to content

Added spaces in downloadlink #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jelledijkstra97 merged 2 commits into from
Jun 17, 2025
Merged

Added spaces in downloadlink #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11aeba0
Added spaces in downloadlink
Jun 16, 2025
b64512d
Fixed tests
Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/controller/generator/mapper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ func getDownloadLinkTitle(datasetFeed pdoknlv3.DatasetFeed, entry pdoknlv3.Entry
} else {
title = escapeQuotes(datasetFeed.Title)
}
title += "-" + downloadLink.GetBlobName()
title += " - " + downloadLink.GetBlobName()
return
}

Expand Down
14 changes: 7 additions & 7 deletions internal/controller/test_data/maximum-atom/expected-output/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: maximum-atom-generator-f9tftfg7bh
name: maximum-atom-generator-8gk8292cf2
namespace: default
labels:
test: test
Expand Down Expand Up @@ -125,27 +125,27 @@ data:
- href: https://test.com/path/downloads/index.json
data: http://localazurite.blob.azurite/container/prefix-1/index.json
rel: index
title: entry-1-title-index.json
title: entry-1-title - index.json
- href: https://test.com/path/downloads/file-1.ext
data: http://localazurite.blob.azurite/container/prefix-1/file-1.ext
rel: alternate
title: entry-1-title-file-1.ext
title: entry-1-title - file-1.ext
time: "2006-01-02T15:04:05Z"
bbox: 1 10 10 100
rights: rights
updated: "2006-01-02T15:04:05Z"
polygon: 50 5 50 10 100 10 100 5 50 5
category:
- term: https://srs-1/test
label: srs-1
label: srs-1
- id: https://test.com/path/entry-2.xml
title: entry-2-title
content: entry-2-content
link:
- href: https://test.com/path/downloads/file-2.ext
data: http://localazurite.blob.azurite/container/prefix-2/file-2.ext
rel: alternate
title: entry-2-title-file-2.ext
title: entry-2-title - file-2.ext
rights: rights
updated: "2006-01-02T15:04:05Z"
polygon: 50 5 50 10 100 10 100 5 50 5
Expand Down Expand Up @@ -187,11 +187,11 @@ data:
- href: https://test.com/path/downloads/file-3.ext
data: http://localazurite.blob.azurite/container/prefix-3/file-3.ext
rel: section
title: feed-2-title-file-3.ext
title: feed-2-title - file-3.ext
- href: https://test.com/path/downloads/file-4.ext
data: http://localazurite.blob.azurite/container/prefix-3/file-4.ext
rel: section
title: feed-2-title-file-4.ext
title: feed-2-title - file-4.ext
rights: rights
updated: "2006-01-02T15:04:05Z"
polygon: 50 5 50 10 100 10 100 5 50 5
Expand Down
4 changes: 2 additions & 2 deletions internal/controller/test_data/minimal-atom/expected-output/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: minimal-atom-generator-fd8bdfdkh6
name: minimal-atom-generator-dm828b69ff
namespace: default
labels:
test: test
Expand Down Expand Up @@ -77,7 +77,7 @@ data:
- href: https://test.com/path/downloads/file.ext
data: http://localazurite.blob.azurite/container/prefix/file.ext
rel: alternate
title: feed-title-file.ext
title: feed-title - file.ext
rights: rights
updated: "2006-01-02T15:04:05Z"
polygon: 50 5 50 10 100 10 100 5 50 5
Expand Down
Loading