Pdok 17792 wms operator unittest #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onform ansible-operator
…onform ansible-operator
…onform ansible-operator
…onform ansible-operator. ogc_webservice_proxy volumeAmounts moet readOnly zijn
…onform ansible-operator. options.VALIDATEREQUESTS
| volumeMounts = []v1.VolumeMount{ | ||
| {Name: "base", MountPath: "/srv/data", ReadOnly: false}, | ||
| {Name: "data", MountPath: "/var/www", ReadOnly: false}, | ||
| // TODO: de volgende volAmount is bedoeld voor CR met mapfile. Bouw daarvoor een aparte test voor |
Collaborator
There was a problem hiding this comment.
Er zou inderdaad nog een test toegevoegd kunnen worden voor een CR met statische mapfile.
Collaborator
Author
There was a problem hiding this comment.
Ik ga het bouwen. Thanks
| typeNamespacedNameWms.Name = sampleWms.Name | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| sampleWms.Spec.Options.RewriteGroupToDataLayers = smoothoperatorutils.Pointer(false) | ||
| //sampleWms.Spec.Options.DisableWebserviceProxy = smoothoperatorutils.Pointer(true) |
Collaborator
There was a problem hiding this comment.
Deze regel in commentaar kan weg.
| } | ||
| volumes = append(volumes, lgVolume, figVolume) | ||
| stylingFilesVolume := v1.Volume{ | ||
| Name: "styling-files", |
Collaborator
There was a problem hiding this comment.
Deze naam zou een constant kunnen zijn net zoals bovenstaande ConfigMap...VolumeNames
| } | ||
|
|
||
| if obj.Type() == pdoknlv3.ServiceTypeWMS { | ||
| stylingFilesVolAm := corev1.VolumeMount{Name: "styling-files", MountPath: "/styling", ReadOnly: true} |
Collaborator
There was a problem hiding this comment.
De naam "styling-files" zou een constant kunnen worden.
…onform ansible-operator. review punten
…onform ansible-operator. review punten
…onform ansible-operator. review punten
jelledijkstra97
previously approved these changes
Apr 29, 2025
damienmulder
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unit tests uitwerken voor WMS Kind in mapserver-operator conform ansible-operator
https://kadaster.atlassian.net/browse/PDOK-17792
Type of change
Unittest bouwen
Checklist: