Skip to content

WFS validation#5

Merged
jelledijkstra97 merged 4 commits intomasterfrom
jd/wfs-admission
Mar 24, 2025
Merged

WFS validation#5
jelledijkstra97 merged 4 commits intomasterfrom
jd/wfs-admission

Conversation

@jelledijkstra97
Copy link
Collaborator

Description

What have you changed and why?

Type of change

(Remove irrelevant options)

  • Minor change (typo, formatting, version bump)
  • New feature
  • Improvement of existing feature
  • Bugfix
  • Refactoring
  • Configuration change
  • Breaking change

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

Copy link
Collaborator

@botenvouwer botenvouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zou je nog een controle kunnen toevoegen op de baseurl zodat deze immutable is. Deze mag net als de labels niet meer in place aangepast worden

@botenvouwer
Copy link
Collaborator

Zou je nog een controle kunnen toevoegen op de baseurl zodat deze immutable is. Deze mag net als de labels niet meer in place aangepast worden

Laat maar zitten. Ik heb er een apart ticket voor gemaakt

@jelledijkstra97 jelledijkstra97 merged commit 97f2781 into master Mar 24, 2025
0 of 6 checks passed
@Daimanta Daimanta deleted the jd/wfs-admission branch April 8, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants