Skip to content

Conversation

@Shalucik
Copy link
Member

Description

removed finalizer code, because we only use the finalizer to delete all child resources
something that k8s already does automatically because of OwnerReferences
therefor it's an unneeded redundancy that creates more problems than it solves
and therefor removed

Type of change

(Remove irrelevant options)

  • Minor change (typo, formatting, version bump)
  • New feature
  • Improvement of existing feature
  • Bugfix
  • Refactoring
  • Configuration change
  • Breaking change

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

@Shalucik Shalucik merged commit f02f784 into master May 20, 2025
4 of 6 checks passed
@Shalucik Shalucik deleted the wr/linting branch May 20, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants