Upgrade to using uv instead of pip #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qartik
reviewed
Dec 15, 2024
qartik
reviewed
Dec 16, 2024
Collaborator
qartik
left a comment
qartik
left a comment
There was a problem hiding this comment.
My primary suggestion is not use pip to install uv anywhere. I haven't tried any steps yet, will be happy to once this concern is settled.
Co-authored-by: Kartik Singhal <[email protected]>
Co-authored-by: Kartik Singhal <[email protected]>
Co-authored-by: Kartik Singhal <[email protected]>
Member
Author
|
Okay, here goes with the workflows... I think I had difficulty using the uv actions for everything last night but hopefully can get them working for everything.... |
Member
Author
|
Woooh hooo workflows seem to be working |
Member
Author
|
Alright, I think I have fixed all the issues you raise @qartik Going to see if all the artifacts look okay. |
Member
Author
|
Artifacts seemingly check out |
qartik
approved these changes
Dec 17, 2024
Collaborator
qartik
left a comment
qartik
left a comment
There was a problem hiding this comment.
Left a question and a minor suggestion, LGTM.
Closed
ciaranra
added a commit
to ciaranra/PECOS-alt
that referenced
this pull request
May 25, 2025
* Unroll broadcast face rotations (PECOS-packages#110) * Upgrade to using uv instead of pip (PECOS-packages#111) * Adding uv to Makefile * Turn on artifact generation (PECOS-packages#117) * Add T gates with active error correction (PECOS-packages#118) * remove t_tel_cor * bugfix in tdg_cor * fix t_cor * Permute all variables of the Steane code (PECOS-packages#114) * compute the swap of CRegs * Add Steane-type and teleportation-based QEC for the Steane code (PECOS-packages#115) * fix qec_steane_z * set flag bit correctly * add qec_steane_.*tel templates * fix Steane.qec_steane_tel * permute all qubits for teleportation * fix teleportation-based QEC * two flag bits for Steane.qec_tel * rename flag_bit --> flag, in agreement with elsewhere in the repo * fix If statement * fix Steane QEC and an incorrect type hint --------- Co-authored-by: Michael A. Perlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use uv instead of pip for workflows and development