-
Notifications
You must be signed in to change notification settings - Fork 11
RNG Crate Patch #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RNG Crate Patch #167
Conversation
|
Having pyo3 in pecos-rng should be re-exported in the |
latest changes responds to this |
ciaranra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This patch refactors the previous workflow of building the RNG library, which started from a C library which was then used to generate a a Rust library to then finally generate python bindings. Now, it uses a single Rust RNG crate, from which Python bindings are directly generated.
Additionally, the global RNG State is no longer static nor global, so any weird behavior involving threads should be nullified. This patch is inherently responding to #166 as well.