Skip to content

Unroll broadcasted operations when producing QASM from SLR #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciaranra merged 6 commits into from
Dec 14, 2024
Merged

Unroll broadcasted operations when producing QASM from SLR #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09e3ce6
unroll broadcast operations
perlinm Dec 9, 2024
9030cbe
add comment
perlinm Dec 9, 2024
71ab897
Merge branch 'development' into unroll-broadcast
perlinm Dec 10, 2024
eb61c9f
add error message
perlinm Dec 10, 2024
424be0f
Fixing regression tests
ciaranra Dec 14, 2024
d311f5e
linting
ciaranra Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions python/quantum-pecos/src/pecos/slr/gen_codes/gen_qasm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from __future__ import annotations

from pecos import __version__
from pecos.slr.vars import QReg


class QASMGenerator:
Expand Down Expand Up @@ -294,14 +295,25 @@ def qgate_qasm(self, op, repr_str: str | None = None):
op.qargs = (op.qargs,)

for q in op.qargs:
if isinstance(q, tuple):
if isinstance(q, QReg):
# Broadcasting across a qubit register is inconsistent with the current Permute
# strategy, so "unroll" broadcast operations to make them act on individual qubits.
# See, for example, https://github.com/PECOS-packages/PECOS/issues/95.
if op.qsize != 1:
msg = "Only single-qubit gates can be broadcast across a qubit register"
raise Exception(msg)
lines = [f"{repr_str} {qubit};" for qubit in q]
str_list.extend(lines)

elif isinstance(q, tuple):
if len(q) != op.qsize:
msg = f"Expected size {op.qsize} got size {len(q)}"
raise Exception(msg)
qs = ",".join([str(qi) for qi in q])
str_list.append(f"{repr_str} {qs};")

str_list.append(f"{repr_str} {str(q)};")
else:
str_list.append(f"{repr_str} {q};")

return "\n".join(str_list)

Expand Down
88 changes: 77 additions & 11 deletions ...sts/pecos/regression/test_qasm/regression_qasm/local_steane_code_program.t_gate_+X_X.qasm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,13 @@ creg saux_verify_prep[32];

barrier sin_d[0], sin_d[1], sin_d[2], sin_d[3], sin_d[4], sin_d[5], sin_d[6], sin_a[0];

reset sin_d;
reset sin_d[0];
reset sin_d[1];
reset sin_d[2];
reset sin_d[3];
reset sin_d[4];
reset sin_d[5];
reset sin_d[6];
reset sin_a[0];
barrier sin_d, sin_a[0];
h sin_d[0];
Expand All @@ -62,7 +68,13 @@ measure sin_a[0] -> sin_verify_prep[0];

if(sin_verify_prep[0] == 1) barrier sin_d[0], sin_d[1], sin_d[2], sin_d[3], sin_d[4], sin_d[5], sin_d[6], sin_a[0];

if(sin_verify_prep[0] == 1) reset sin_d;
if(sin_verify_prep[0] == 1) reset sin_d[0];
if(sin_verify_prep[0] == 1) reset sin_d[1];
if(sin_verify_prep[0] == 1) reset sin_d[2];
if(sin_verify_prep[0] == 1) reset sin_d[3];
if(sin_verify_prep[0] == 1) reset sin_d[4];
if(sin_verify_prep[0] == 1) reset sin_d[5];
if(sin_verify_prep[0] == 1) reset sin_d[6];
if(sin_verify_prep[0] == 1) reset sin_a[0];
if(sin_verify_prep[0] == 1) barrier sin_d, sin_a[0];
if(sin_verify_prep[0] == 1) h sin_d[0];
Expand All @@ -88,7 +100,13 @@ if(sin_verify_prep[0] == 1) measure sin_a[0] -> sin_verify_prep[0];

if(sin_verify_prep[0] == 1) barrier sin_d[0], sin_d[1], sin_d[2], sin_d[3], sin_d[4], sin_d[5], sin_d[6], sin_a[0];

if(sin_verify_prep[0] == 1) reset sin_d;
if(sin_verify_prep[0] == 1) reset sin_d[0];
if(sin_verify_prep[0] == 1) reset sin_d[1];
if(sin_verify_prep[0] == 1) reset sin_d[2];
if(sin_verify_prep[0] == 1) reset sin_d[3];
if(sin_verify_prep[0] == 1) reset sin_d[4];
if(sin_verify_prep[0] == 1) reset sin_d[5];
if(sin_verify_prep[0] == 1) reset sin_d[6];
if(sin_verify_prep[0] == 1) reset sin_a[0];
if(sin_verify_prep[0] == 1) barrier sin_d, sin_a[0];
if(sin_verify_prep[0] == 1) h sin_d[0];
Expand All @@ -112,7 +130,13 @@ if(sin_verify_prep[0] == 1) cx sin_d[3], sin_a[0];
if(sin_verify_prep[0] == 1) measure sin_a[0] -> sin_verify_prep[0];

// Logical H
h sin_d;
h sin_d[0];
h sin_d[1];
h sin_d[2];
h sin_d[3];
h sin_d[4];
h sin_d[5];
h sin_d[6];
saux_scratch = 0;
reset saux_d[6];
ry(0.7853981633974483) saux_d[6];
Expand Down Expand Up @@ -371,10 +395,22 @@ if(saux_syn_meas == 6) saux_c[2] = saux_c[2] ^ 1;
saux_c[2] = saux_c[2] ^ saux_c[3];
sin_c[5] = saux_c[2];
// Logical SZ
if(sin_c[5] == 1) rz(-pi/2) sin_d;
if(sin_c[5] == 1) rz(-pi/2) sin_d[0];
if(sin_c[5] == 1) rz(-pi/2) sin_d[1];
if(sin_c[5] == 1) rz(-pi/2) sin_d[2];
if(sin_c[5] == 1) rz(-pi/2) sin_d[3];
if(sin_c[5] == 1) rz(-pi/2) sin_d[4];
if(sin_c[5] == 1) rz(-pi/2) sin_d[5];
if(sin_c[5] == 1) rz(-pi/2) sin_d[6];
// Destructive logical X measurement
// Logical SYdg
ry(-pi/2) sin_d;
ry(-pi/2) sin_d[0];
ry(-pi/2) sin_d[1];
ry(-pi/2) sin_d[2];
ry(-pi/2) sin_d[3];
ry(-pi/2) sin_d[4];
ry(-pi/2) sin_d[5];
ry(-pi/2) sin_d[6];

barrier sin_d;

Expand Down Expand Up @@ -824,7 +860,13 @@ m_reject[1] = saux_scratch[2];

barrier sin_d[0], sin_d[1], sin_d[2], sin_d[3], sin_d[4], sin_d[5], sin_d[6], sin_a[0];

reset sin_d;
reset sin_d[0];
reset sin_d[1];
reset sin_d[2];
reset sin_d[3];
reset sin_d[4];
reset sin_d[5];
reset sin_d[6];
reset sin_a[0];
barrier sin_d, sin_a[0];
h sin_d[0];
Expand All @@ -850,7 +892,13 @@ measure sin_a[0] -> sin_verify_prep[0];

if(sin_verify_prep[0] == 1) barrier sin_d[0], sin_d[1], sin_d[2], sin_d[3], sin_d[4], sin_d[5], sin_d[6], sin_a[0];

if(sin_verify_prep[0] == 1) reset sin_d;
if(sin_verify_prep[0] == 1) reset sin_d[0];
if(sin_verify_prep[0] == 1) reset sin_d[1];
if(sin_verify_prep[0] == 1) reset sin_d[2];
if(sin_verify_prep[0] == 1) reset sin_d[3];
if(sin_verify_prep[0] == 1) reset sin_d[4];
if(sin_verify_prep[0] == 1) reset sin_d[5];
if(sin_verify_prep[0] == 1) reset sin_d[6];
if(sin_verify_prep[0] == 1) reset sin_a[0];
if(sin_verify_prep[0] == 1) barrier sin_d, sin_a[0];
if(sin_verify_prep[0] == 1) h sin_d[0];
Expand All @@ -874,7 +922,13 @@ if(sin_verify_prep[0] == 1) cx sin_d[3], sin_a[0];
if(sin_verify_prep[0] == 1) measure sin_a[0] -> sin_verify_prep[0];

// Logical H
h sin_d;
h sin_d[0];
h sin_d[1];
h sin_d[2];
h sin_d[3];
h sin_d[4];
h sin_d[5];
h sin_d[6];
// Transversal Logical CX
barrier sin_d, saux_d;
cx sin_d[0], saux_d[0];
Expand Down Expand Up @@ -927,10 +981,22 @@ if(saux_syn_meas == 6) saux_c[2] = saux_c[2] ^ 1;
saux_c[2] = saux_c[2] ^ saux_c[3];
m_t[0] = saux_c[2];
// Logical SZ
if(sin_c[5] == 1) rz(-pi/2) sin_d;
if(sin_c[5] == 1) rz(-pi/2) sin_d[0];
if(sin_c[5] == 1) rz(-pi/2) sin_d[1];
if(sin_c[5] == 1) rz(-pi/2) sin_d[2];
if(sin_c[5] == 1) rz(-pi/2) sin_d[3];
if(sin_c[5] == 1) rz(-pi/2) sin_d[4];
if(sin_c[5] == 1) rz(-pi/2) sin_d[5];
if(sin_c[5] == 1) rz(-pi/2) sin_d[6];
// Destructive logical X measurement
// Logical SYdg
ry(-pi/2) sin_d;
ry(-pi/2) sin_d[0];
ry(-pi/2) sin_d[1];
ry(-pi/2) sin_d[2];
ry(-pi/2) sin_d[3];
ry(-pi/2) sin_d[4];
ry(-pi/2) sin_d[5];
ry(-pi/2) sin_d[6];

barrier sin_d;

Expand Down
88 changes: 77 additions & 11 deletions ...sts/pecos/regression/test_qasm/regression_qasm/local_steane_code_program.t_gate_+X_Y.qasm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,13 @@ creg saux_verify_prep[32];

barrier sin_d[0], sin_d[1], sin_d[2], sin_d[3], sin_d[4], sin_d[5], sin_d[6], sin_a[0];

reset sin_d;
reset sin_d[0];
reset sin_d[1];
reset sin_d[2];
reset sin_d[3];
reset sin_d[4];
reset sin_d[5];
reset sin_d[6];
reset sin_a[0];
barrier sin_d, sin_a[0];
h sin_d[0];
Expand All @@ -62,7 +68,13 @@ measure sin_a[0] -> sin_verify_prep[0];

if(sin_verify_prep[0] == 1) barrier sin_d[0], sin_d[1], sin_d[2], sin_d[3], sin_d[4], sin_d[5], sin_d[6], sin_a[0];

if(sin_verify_prep[0] == 1) reset sin_d;
if(sin_verify_prep[0] == 1) reset sin_d[0];
if(sin_verify_prep[0] == 1) reset sin_d[1];
if(sin_verify_prep[0] == 1) reset sin_d[2];
if(sin_verify_prep[0] == 1) reset sin_d[3];
if(sin_verify_prep[0] == 1) reset sin_d[4];
if(sin_verify_prep[0] == 1) reset sin_d[5];
if(sin_verify_prep[0] == 1) reset sin_d[6];
if(sin_verify_prep[0] == 1) reset sin_a[0];
if(sin_verify_prep[0] == 1) barrier sin_d, sin_a[0];
if(sin_verify_prep[0] == 1) h sin_d[0];
Expand All @@ -88,7 +100,13 @@ if(sin_verify_prep[0] == 1) measure sin_a[0] -> sin_verify_prep[0];

if(sin_verify_prep[0] == 1) barrier sin_d[0], sin_d[1], sin_d[2], sin_d[3], sin_d[4], sin_d[5], sin_d[6], sin_a[0];

if(sin_verify_prep[0] == 1) reset sin_d;
if(sin_verify_prep[0] == 1) reset sin_d[0];
if(sin_verify_prep[0] == 1) reset sin_d[1];
if(sin_verify_prep[0] == 1) reset sin_d[2];
if(sin_verify_prep[0] == 1) reset sin_d[3];
if(sin_verify_prep[0] == 1) reset sin_d[4];
if(sin_verify_prep[0] == 1) reset sin_d[5];
if(sin_verify_prep[0] == 1) reset sin_d[6];
if(sin_verify_prep[0] == 1) reset sin_a[0];
if(sin_verify_prep[0] == 1) barrier sin_d, sin_a[0];
if(sin_verify_prep[0] == 1) h sin_d[0];
Expand All @@ -112,7 +130,13 @@ if(sin_verify_prep[0] == 1) cx sin_d[3], sin_a[0];
if(sin_verify_prep[0] == 1) measure sin_a[0] -> sin_verify_prep[0];

// Logical H
h sin_d;
h sin_d[0];
h sin_d[1];
h sin_d[2];
h sin_d[3];
h sin_d[4];
h sin_d[5];
h sin_d[6];
saux_scratch = 0;
reset saux_d[6];
ry(0.7853981633974483) saux_d[6];
Expand Down Expand Up @@ -371,10 +395,22 @@ if(saux_syn_meas == 6) saux_c[2] = saux_c[2] ^ 1;
saux_c[2] = saux_c[2] ^ saux_c[3];
sin_c[5] = saux_c[2];
// Logical SZ
if(sin_c[5] == 1) rz(-pi/2) sin_d;
if(sin_c[5] == 1) rz(-pi/2) sin_d[0];
if(sin_c[5] == 1) rz(-pi/2) sin_d[1];
if(sin_c[5] == 1) rz(-pi/2) sin_d[2];
if(sin_c[5] == 1) rz(-pi/2) sin_d[3];
if(sin_c[5] == 1) rz(-pi/2) sin_d[4];
if(sin_c[5] == 1) rz(-pi/2) sin_d[5];
if(sin_c[5] == 1) rz(-pi/2) sin_d[6];
// Destructive logical Y measurement
// Logical SX
rx(-pi/2) sin_d;
rx(-pi/2) sin_d[0];
rx(-pi/2) sin_d[1];
rx(-pi/2) sin_d[2];
rx(-pi/2) sin_d[3];
rx(-pi/2) sin_d[4];
rx(-pi/2) sin_d[5];
rx(-pi/2) sin_d[6];

barrier sin_d;

Expand Down Expand Up @@ -826,7 +862,13 @@ m_reject[1] = saux_scratch[2];

barrier sin_d[0], sin_d[1], sin_d[2], sin_d[3], sin_d[4], sin_d[5], sin_d[6], sin_a[0];

reset sin_d;
reset sin_d[0];
reset sin_d[1];
reset sin_d[2];
reset sin_d[3];
reset sin_d[4];
reset sin_d[5];
reset sin_d[6];
reset sin_a[0];
barrier sin_d, sin_a[0];
h sin_d[0];
Expand All @@ -852,7 +894,13 @@ measure sin_a[0] -> sin_verify_prep[0];

if(sin_verify_prep[0] == 1) barrier sin_d[0], sin_d[1], sin_d[2], sin_d[3], sin_d[4], sin_d[5], sin_d[6], sin_a[0];

if(sin_verify_prep[0] == 1) reset sin_d;
if(sin_verify_prep[0] == 1) reset sin_d[0];
if(sin_verify_prep[0] == 1) reset sin_d[1];
if(sin_verify_prep[0] == 1) reset sin_d[2];
if(sin_verify_prep[0] == 1) reset sin_d[3];
if(sin_verify_prep[0] == 1) reset sin_d[4];
if(sin_verify_prep[0] == 1) reset sin_d[5];
if(sin_verify_prep[0] == 1) reset sin_d[6];
if(sin_verify_prep[0] == 1) reset sin_a[0];
if(sin_verify_prep[0] == 1) barrier sin_d, sin_a[0];
if(sin_verify_prep[0] == 1) h sin_d[0];
Expand All @@ -876,7 +924,13 @@ if(sin_verify_prep[0] == 1) cx sin_d[3], sin_a[0];
if(sin_verify_prep[0] == 1) measure sin_a[0] -> sin_verify_prep[0];

// Logical H
h sin_d;
h sin_d[0];
h sin_d[1];
h sin_d[2];
h sin_d[3];
h sin_d[4];
h sin_d[5];
h sin_d[6];
// Transversal Logical CX
barrier sin_d, saux_d;
cx sin_d[0], saux_d[0];
Expand Down Expand Up @@ -929,10 +983,22 @@ if(saux_syn_meas == 6) saux_c[2] = saux_c[2] ^ 1;
saux_c[2] = saux_c[2] ^ saux_c[3];
m_t[0] = saux_c[2];
// Logical SZ
if(sin_c[5] == 1) rz(-pi/2) sin_d;
if(sin_c[5] == 1) rz(-pi/2) sin_d[0];
if(sin_c[5] == 1) rz(-pi/2) sin_d[1];
if(sin_c[5] == 1) rz(-pi/2) sin_d[2];
if(sin_c[5] == 1) rz(-pi/2) sin_d[3];
if(sin_c[5] == 1) rz(-pi/2) sin_d[4];
if(sin_c[5] == 1) rz(-pi/2) sin_d[5];
if(sin_c[5] == 1) rz(-pi/2) sin_d[6];
// Destructive logical Y measurement
// Logical SX
rx(-pi/2) sin_d;
rx(-pi/2) sin_d[0];
rx(-pi/2) sin_d[1];
rx(-pi/2) sin_d[2];
rx(-pi/2) sin_d[3];
rx(-pi/2) sin_d[4];
rx(-pi/2) sin_d[5];
rx(-pi/2) sin_d[6];

barrier sin_d;

Expand Down
Loading
Loading