Tests with math expression condition table for initial assignments #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two test cases where mathematical expressions are used in the condition table for conditions that set model initial values. The generated test values match those computed by PEtab.jl.
0026is a modified version of0020, where the initial assignments of speciesAandBare now given by mathematical expressions that combine both parameters to be estimated and parameters that are not estimated.0027is a modified version of0005, where the assignment to the parameteroffset_Ais given by a mathematical expression combining parameters to be estimated, parameters not to be estimated, and numerical values.Why these are relevant
In PEtab v1, the condition table did not allow mapping mathematical expressions, only constant numerical values or parameters. Allowing mathematical expressions to be mapped is a noticeably harder problem to deal with for an importer, especially for computing gradients.