Two PEtab conditions simultaneously #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweindl
approved these changes
Dec 16, 2025
Member
dweindl
left a comment
dweindl
left a comment
There was a problem hiding this comment.
Thanks once more. Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case with two PEtab conditions triggering simultaneously. As per the spec, they should be treated as a single event.
I have added this as test
0031. I’ve also updated the PRs so that #105, #106, and #107 can all be merged subsequently of each other.This should be the last test case for today, as I currently can not think of any remaining untested features that would cause problems for importers.