Open
Conversation
Owner
|
Hi Noah, many thanks for the update! I will definitely have a look at it and test this code on Python 2 and 3. This was one of the secondary outputs of my thesis, and at the time I focused more on how it could work best for my Python 2 environment, but I'll continue the work on it! (Sorry for not replying earlier, I somehow never got any notifications about your contributions) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey - thanks for putting this together! I'm working on a project that involves automating some Kubios analysis, and this package is just what I needed to handle the output. Because my project is done in python3 I ran python-modernize on your code and added a setup.py. (By the way, while I was doing that I noticed that all the licensing in the code is BSD 3-clause, but on PyPi it's listed as MIT - not sure why that is.) It looks like this should all run in python 2 and python 3 now, but let me know if you see anything in my changes you'd like revised.