Multiple fixes and enhancements #41
Conversation
Updated author information
PHOENIX-MEDIA
left a comment
PHOENIX-MEDIA
left a comment
There was a problem hiding this comment.
Please review some of the commits and make appropriate changes. Thanks for your support!
| $this->_prepareTotals(); | ||
|
|
||
| if ($this->_totalObject && $this->_totalObject->getCodFee()) { | ||
| if ($this->_totalObject && $this->_totalObject->getCodFee() && Mage::getStoreConfigFlag('payment/phoenix_cashondelivery/display_zero_fee')) { |
There was a problem hiding this comment.
This will not work... If codFee check returns false the last && will not be validated. If the codFee Check returns true and display_zero_fee is set to false the total block is not added even if a fee is set.
| // If order is instance of Phoenix_CashOnDelivery_Model_CashOnDelivery | ||
| if ($order->getPayment()->getMethodInstance()->getCode() == 'phoenix_cashondelivery' && | ||
| // Can be invoiced | ||
| $order->canvoice() && |
There was a problem hiding this comment.
Typo: canvoice() should be canInvoice()
| <show_in_store>1</show_in_store> | ||
| <fields> | ||
| <active translate="label"> | ||
| <enable translate="label"> |
There was a problem hiding this comment.
Mage_Payment_Model_Method_Abstract::isAvailable() checks for "active" config path, not "enable".
| <show_in_website>1</show_in_website> | ||
| <show_in_store>1</show_in_store> | ||
| <depends> | ||
| <enable>1</enable> |
There was a problem hiding this comment.
Hiding config data for the payment method when disabled is not something we want to add. Displaying the configuration is often desired even if the method is (temporarily) disabled.
2 participants
Fix localization issues
Add locale 'en_GB' and 'pt_PT'
SR-714 allow capture offline'
Fixed 'Display Zero Fee' in customer account order view (#21)
Add 'cod_fee', 'base_cod_fee' attributes to webservices (#33)
Update to better fit ECG/PSR-2
Removed not used observer method, Renamed observer methods
Hide config options if module is disabled
Add 'Create Invoice Option'
Improve locale 'it_IT'