Fix return-type for PossibleInstructionResult of EnumInstructionResult
#119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructionResult Added method `InstructionResults()` which returns the same data as `PossibleInstructionResult()` but as an array. Marked the `PossibleInstructionResult()` method as obulete, use `InstructionResults()` instead.
seveneleven
reviewed
Oct 13, 2025
src/Moryx.ControlSystem/VisualInstructions/EnumInstructionResult.cs
Outdated
Show resolved
Hide resolved
- using invariant culture when parsing values to string
1nf0rmagician
approved these changes
Oct 14, 2025
DosenSuppe
deleted the
fix/activeinstruction-enuminstructionresults-results-mismatch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the ActiveInstrucion marks it's property
PossibleResultsof typeIReadOnlyListas obsolete, I also marked thePossibleInstructionResult()method ofEnumInstructionResultas obsolete and added the methodInstructionResults()which returns the same data asPossibleInstructionResult()but as an array.