Skip to content

Add missing configuration options on MqttTopicJson and documentation#1133

Merged
1nf0rmagician merged 4 commits intodevfrom
feat/mqtt-options
Mar 4, 2026
Merged

Add missing configuration options on MqttTopicJson and documentation#1133
1nf0rmagician merged 4 commits intodevfrom
feat/mqtt-options

Conversation

@andreniggemann
Copy link
Contributor

@andreniggemann andreniggemann commented Feb 27, 2026

Summary

Add currently not exposed options to MqttTopicJson and make GetSystemTextJsonOptions() virtual to allow full customization if necessary.

Added missing documentation for the configuration options for the mqtt drivers and it's topics.

Applied suggestion to MqttTopicPrimitive to use switch expressions and removed unnecessary cases. Enabled UTF-8 support instead of ASCII.

Linked Issues

Closes #1092

Relevant logs and/or screenshots

Breaking Changes

Checklist for Submitter

  • I have tested these changes locally
  • I have updated documentation as needed
  • I have added or updated tests as appropriate
  • I have used clear and descriptive commit messages

Review

Typical tasks

  • Merge request is well described
  • Added Obsolete attributes if necessary
  • Critical sections are documented in code
  • Tests available or extended
  • Documentation is created / updated
  • Running in test environment
  • Manual is created / updated
  • Ports to other maintained versions are created

Clean code

  • All unused references are removed
  • Clean code rules are respected with passion (naming, ...)
  • Avoid copy and pasted code snippets

Add currently not exposed options to MqttTopicJson and make GetSystemTextJsonOptions() virtual to allow full customization if necessary.

Applied suggestion to MqttTopicPrimitive to use switch expressions and removed unnecessary cases. Enabled UTF-8 support instead of ASCII.
…Text.Json equivalent into JsonOptionsExtension.

Rename PascalCase formatting to default, because it's misleading.
1nf0rmagician
1nf0rmagician previously approved these changes Mar 4, 2026
Copy link
Member

@1nf0rmagician 1nf0rmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflict and remember to squash and merge 👍

@1nf0rmagician 1nf0rmagician merged commit a898768 into dev Mar 4, 2026
8 checks passed
@1nf0rmagician 1nf0rmagician deleted the feat/mqtt-options branch March 4, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing json configurations to MqttJsonTopic

3 participants