Add missing configuration options on MqttTopicJson and documentation#1133
Merged
1nf0rmagician merged 4 commits intodevfrom Mar 4, 2026
Merged
Add missing configuration options on MqttTopicJson and documentation#11331nf0rmagician merged 4 commits intodevfrom
1nf0rmagician merged 4 commits intodevfrom
Conversation
Add currently not exposed options to MqttTopicJson and make GetSystemTextJsonOptions() virtual to allow full customization if necessary. Applied suggestion to MqttTopicPrimitive to use switch expressions and removed unnecessary cases. Enabled UTF-8 support instead of ASCII.
dbeuchler
reviewed
Mar 2, 2026
…Text.Json equivalent into JsonOptionsExtension. Rename PascalCase formatting to default, because it's misleading.
a90d6b1 to
43abeea
Compare
1nf0rmagician
previously approved these changes
Mar 4, 2026
Member
1nf0rmagician
left a comment
There was a problem hiding this comment.
Please resolve the merge conflict and remember to squash and merge 👍
1nf0rmagician
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add currently not exposed options to MqttTopicJson and make GetSystemTextJsonOptions() virtual to allow full customization if necessary.
Added missing documentation for the configuration options for the mqtt drivers and it's topics.
Applied suggestion to MqttTopicPrimitive to use switch expressions and removed unnecessary cases. Enabled UTF-8 support instead of ASCII.
Linked Issues
Closes #1092
Relevant logs and/or screenshots
Breaking Changes
Checklist for Submitter
Review
Typical tasks
Obsoleteattributes if necessaryClean code