Port: Fix missing localization for ProcessDataListenerConfig #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seveneleven
approved these changes
Oct 7, 2025
seveneleven
previously approved these changes
Oct 7, 2025
…ENIXCONTACT/fix/missing-localization-for-processdatalistenerconfig Fix missing localization for `ProcessDataListenerConfig` (cherry picked from commit 28c1c0c2d1ffce75cd111d740c2834d9762377ec)
1nf0rmagician
force-pushed
the
port/missing-localization-for-processdatalistenerconfig-to-future
branch
from
bef6468 to
4f3149e
Compare
seveneleven
approved these changes
Oct 9, 2025
1nf0rmagician
deleted the
port/missing-localization-for-processdatalistenerconfig-to-future
branch
dbeuchler
reviewed
Oct 10, 2025
| /// </summary> | ||
| [DataMember] | ||
| [Description("Unique Name of the Listener")] | ||
| [Display(Name = nameof(Strings.LISTENERNAME), Description = nameof(Strings.LISTENERNAME_DESCRIPTION), ResourceType = typeof(Strings))] |
Member
There was a problem hiding this comment.
Naming convention of the resource keys is <ClassName>_<PropertyName>_DisplayName or <ClassName>_<PropertyName>_Description @DosenSuppe could you fix that in MORYX-Factory and then update the port?
Sample for here: ProcessDataListenerConfig_ListenerName_DisplayName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing localization for
ProcessDataListenerConfig(cherry picked from commit 28c1c0c2d1ffce75cd111d740c2834d9762377ec)
PHOENIXCONTACT/MORYX-Factory#116