Merged
Conversation
dbeuchler
requested changes
Nov 5, 2025
src/Tests/Moryx.Recources.Mqtt.Tests/TestDriverMqttJsonTopic.cs
Outdated
Show resolved
Hide resolved
Member
1nf0rmagician
left a comment
There was a problem hiding this comment.
You already mentioned that there are breaking changes in here, would you put them in the migration guide please? 🙂
src/Moryx.Drivers.Mqtt/MqttDriver.cs
Outdated
| } | ||
| } | ||
|
|
||
| /// <summary> |
Member
There was a problem hiding this comment.
would you put these properties next to the other props?
src/Moryx.Drivers.Mqtt/MqttDriver.cs
Outdated
|
|
||
| internal void DelayedConnectionAttempt() | ||
| { | ||
| ParallelOperations.ScheduleExecution(() => Connect(false).ContinueWith(t => |
Member
There was a problem hiding this comment.
Do you want to remember the operation id here to cancel it in the OnStop of the driver?
Contributor
Author
There was a problem hiding this comment.
I know included this in a slightly modified form.
I placed it in OnDisconnect which is called by OnStop. This has the benefit that it should also work for other situations where a disconnect is requested.
…ecause it's deprecated to access the payload as a byte[] switch the deserialize api to ArraySegment<byte>
…in connected state. Can happen when debugger is connected
Ignore misconfigured topics while sending. Add some logging and error handling
…tion as enums or as strings
Add description attributes and xml comments. Fix some formatting issues.
…se, including update to the new PayloadType of MQTTnet ReadOnlySequence.
e60394a to
0910751
Compare
dbeuchler
reviewed
Dec 2, 2025
dbeuchler
reviewed
Dec 2, 2025
dbeuchler
reviewed
Dec 2, 2025
dbeuchler
reviewed
Dec 2, 2025
dbeuchler
reviewed
Dec 2, 2025
dbeuchler
reviewed
Dec 2, 2025
dbeuchler
reviewed
Dec 4, 2025
dbeuchler
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfixes:
Cleanup:
Features: